Remove the deprecated ToolchainCluster.Spec fields #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metlos
requested review from
MatousJobanek,
xcoulon,
alexeykazakov,
rajivnathan,
ranakan19 and
mfrancisc
as code owners
This was referenced Oct 2, 2024
Merged
Merged
… into deprecate-tc-spec-fields-contd5
alexeykazakov
approved these changes
Oct 3, 2024
We need this indirection because we need to make the removal in two steps so that the potentially different versions of the CRD in host and member stay compatible.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This removes all of the fields from the
ToolchainCluster.Specapart from the reference to the secret containing the kubeconfig for connecting to the cluster. The API endpoint and the operator namespace are now located as fields in theToolchainCluster.Status.Checks
Did you run
make generatetarget? yesDid
make generatechange anything in other projects (host-operator, member-operator)? yesIn case of new CRD, did you the following? NA
resources/setup/roles/host.yamlin the sandbox-sre repositoryPROJECTfile: https://github.com/codeready-toolchain/host-operator/blob/master/PROJECTCSVfile: https://github.com/codeready-toolchain/host-operator/blob/master/config/manifests/bases/host-operator.clusterserviceversion.yamlIn case other projects are changed, please provides PR links.
Other related PRs that update the use sites of the removed fields:
These other related PRs can be merged independently of this PR, but care needs to be taken in the meantime not to reintroduce the usage of the removed fields until
toolchain-e2eandksctlupdate to the version of the api introduced in this PR.