Skip to content

Commit

Permalink
Update naming and tests
Browse files Browse the repository at this point in the history
  • Loading branch information
rajivnathan committed Oct 16, 2024
1 parent b608d0e commit a27f419
Show file tree
Hide file tree
Showing 10 changed files with 16 additions and 13 deletions.
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
apiVersion: template.openshift.io/v1
kind: Template
metadata:
name: intel-large-cluster-resources
name: intellarge-cluster-resources
objects:
- apiVersion: quota.openshift.io/v1
kind: ClusterResourceQuota
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
apiVersion: template.openshift.io/v1
kind: Template
metadata:
name: intel-large-dev
name: intellarge-dev
objects:
- apiVersion: v1
kind: Namespace
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
apiVersion: template.openshift.io/v1
kind: Template
metadata:
name: intel-large-spacerole-admin
name: intellarge-spacerole-admin
objects:

# Rolebindings that grant permissions to the users in their own namespaces
Expand Down
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
apiVersion: template.openshift.io/v1
kind: Template
metadata:
name: intel-large-tier
name: intellarge-tier
objects:
- kind: NSTemplateTier
apiVersion: toolchain.dev.openshift.com/v1alpha1
metadata:
name: intel-large
name: intellarge
namespace: ${NAMESPACE}
spec:
clusterResources:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
apiVersion: template.openshift.io/v1
kind: Template
metadata:
name: intel-medium-cluster-resources
name: intelmedium-cluster-resources
objects:
- apiVersion: quota.openshift.io/v1
kind: ClusterResourceQuota
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
apiVersion: template.openshift.io/v1
kind: Template
metadata:
name: intel-medium-dev
name: intelmedium-dev
objects:
- apiVersion: v1
kind: Namespace
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
apiVersion: template.openshift.io/v1
kind: Template
metadata:
name: intel-medium-spacerole-admin
name: intelmedium-spacerole-admin
objects:

# Rolebindings that grant permissions to the users in their own namespaces
Expand Down
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
apiVersion: template.openshift.io/v1
kind: Template
metadata:
name: intel-medium-tier
name: intelmedium-tier
objects:
- kind: NSTemplateTier
apiVersion: toolchain.dev.openshift.com/v1alpha1
metadata:
name: intel-medium
name: intelmedium
namespace: ${NAMESPACE}
spec:
clusterResources:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,14 +32,14 @@ var expectedProdTiers = []string{
"base1ns6didler",
"baselarge",
"baseextendedidling",
"intel-medium",
"intel-large",
"intelmedium",
"intellarge",
"test",
}

func nsTypes(tier string) []string {
switch tier {
case "base1ns", "base1nsnoidling", "base1ns6didler", "intel-medium", "intel-large", "test":
case "base1ns", "base1nsnoidling", "base1ns6didler", "intelmedium", "intellarge", "test":
return []string{"dev"}
default:
return []string{"dev", "stage"}
Expand Down
3 changes: 3 additions & 0 deletions pkg/templates/usertiers/usertier_generator_whitebox_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ var expectedProdTiers = []string{
"deactivate90",
"deactivate180",
"deactivate365",
"intel",
}

var expectedTestTiers = []string{
Expand Down Expand Up @@ -190,6 +191,8 @@ func TestNewUserTier(t *testing.T) {
assert.Equal(t, 180, tier.Spec.DeactivationTimeoutDays)
case "deactivate365":
assert.Equal(t, 365, tier.Spec.DeactivationTimeoutDays)
case "intel":
assert.Equal(t, 18, tier.Spec.DeactivationTimeoutDays)
default:
require.Fail(t, "found unexpected tier", "tier '%s' found but not handled", tier.Name)
}
Expand Down

0 comments on commit a27f419

Please sign in to comment.