Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing open api marker to ws structs #482

Merged
merged 2 commits into from
Oct 12, 2023

Conversation

mfrancisc
Copy link
Contributor

generated files for: codeready-toolchain/api#381

Copy link
Contributor

@MatousJobanek MatousJobanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't forget to update also the dependency on the api repo when you merge it

@openshift-ci
Copy link

openshift-ci bot commented Oct 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MatousJobanek, mfrancisc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #482 (47ab55a) into master (a026dbe) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #482   +/-   ##
=======================================
  Coverage   82.02%   82.02%           
=======================================
  Files          30       30           
  Lines        3444     3444           
=======================================
  Hits         2825     2825           
  Misses        474      474           
  Partials      145      145           

@sonarcloud
Copy link

sonarcloud bot commented Oct 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@mfrancisc
Copy link
Contributor Author

don't forget to update also the dependency on the api repo when you merge it

thanks for the reminder! Done in 47ab55a

@mfrancisc mfrancisc merged commit 70d1c48 into codeready-toolchain:master Oct 12, 2023
13 of 14 checks passed
@mfrancisc mfrancisc deleted the fixwsapi branch October 12, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants