Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved PollUpdateSignup function to common package #340

Merged
merged 5 commits into from
Jul 28, 2023

Conversation

sbryzak
Copy link
Contributor

@sbryzak sbryzak commented Jul 25, 2023

This PR simply consolidates the two duplicate pollUpdateSignup functions from the signup and verification services into a single place where it is reused by both.

@openshift-ci
Copy link

openshift-ci bot commented Jul 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexeykazakov, mfrancisc, sbryzak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [alexeykazakov,sbryzak]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sbryzak
Copy link
Contributor Author

sbryzak commented Jul 27, 2023

/retest

@sonarcloud
Copy link

sonarcloud bot commented Jul 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
12.9% 12.9% Duplication

@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Patch coverage: 58.33% and project coverage change: -0.32% ⚠️

Comparison is base (e0e9ba9) 77.84% compared to head (4b46afb) 77.53%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #340      +/-   ##
==========================================
- Coverage   77.84%   77.53%   -0.32%     
==========================================
  Files          31       31              
  Lines        2767     2733      -34     
==========================================
- Hits         2154     2119      -35     
- Misses        528      529       +1     
  Partials       85       85              
Flag Coverage Δ
unittests 77.53% <58.33%> (-0.32%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/verification/service/verification_service.go 75.79% <54.54%> (-2.02%) ⬇️
pkg/signup/service/signup_service.go 93.25% <100.00%> (-0.31%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sbryzak sbryzak merged commit 19d3130 into codeready-toolchain:master Jul 28, 2023
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants