-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify social event support in internal landing page #456
Simplify social event support in internal landing page #456
Conversation
Quality Gate passedIssues Measures |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexeykazakov, sbryzak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #456 +/- ##
=======================================
Coverage 78.73% 78.73%
=======================================
Files 42 42
Lines 2742 2742
=======================================
Hits 2159 2159
Misses 490 490
Partials 93 93
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I'm curious, how can we make sure that all hackathon users will have verification required (so they have a chance to input the Activation Code) |
ada25da
into
codeready-toolchain:master
@xcoulon I think Matous explained it here: https://redhat-internal.slack.com/archives/C07JLT363ME/p1724767269456019?thread_ts=1724748364.070099&cid=C07JLT363ME |
I believe this was rather a 1-time hack to verify the workflow. But @alexeykazakov mentioned a more permanent solution in Slack |
This PR introduces a few changes to the internal landing page to better support social events:
OpenShift AI
card and update the card descriptions (the Dev Spaces card is still hidden):+
:Activation Code
field only: