Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop BaseService from MemberClusterService & use Client directly #477

Conversation

MatousJobanek
Copy link
Contributor

@MatousJobanek MatousJobanek commented Oct 4, 2024

  • drops BaseService from MemberClusterService
  • uses the controller-runtime client directly for communication with k8s api
  • the implementation of the SignupService is set directly (not via the BaseService) which simplifies the tests

this is a prerequisite for dropping the InformerService KUBESAW-198

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.43%. Comparing base (fb4418b) to head (1713c85).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pkg/proxy/service/cluster_service.go 88.88% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #477      +/-   ##
==========================================
- Coverage   85.45%   85.43%   -0.03%     
==========================================
  Files          33       33              
  Lines        2523     2519       -4     
==========================================
- Hits         2156     2152       -4     
  Misses        281      281              
  Partials       86       86              
Flag Coverage Δ
unittests 85.43% <90.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Oct 7, 2024

Copy link
Contributor

@mfrancisc mfrancisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

Copy link

openshift-ci bot commented Oct 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexeykazakov, MatousJobanek, mfrancisc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [MatousJobanek,alexeykazakov,mfrancisc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@MatousJobanek MatousJobanek merged commit 4797d02 into codeready-toolchain:master Oct 8, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants