Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to set role for new spacebinding #320

Merged
merged 1 commit into from
Jul 11, 2023
Merged

Add option to set role for new spacebinding #320

merged 1 commit into from
Jul 11, 2023

Conversation

rajivnathan
Copy link
Contributor

@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Merging #320 (14927ff) into master (719b093) will increase coverage by 0.11%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #320      +/-   ##
==========================================
+ Coverage   76.18%   76.30%   +0.11%     
==========================================
  Files          41       41              
  Lines        1810     1819       +9     
==========================================
+ Hits         1379     1388       +9     
  Misses        385      385              
  Partials       46       46
Impacted Files Coverage Δ
pkg/spacebinding/spacebinding.go 91.17% <100.00%> (+3.17%) ⬆️

@sonarcloud
Copy link

sonarcloud bot commented Jul 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
4.0% 4.0% Duplication

@rajivnathan rajivnathan merged commit 57def48 into codeready-toolchain:master Jul 11, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexeykazakov alexeykazakov alexeykazakov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rajivnathan @alexeykazakov