SANDBOX-681: add ban reason to NewBannedUser func

[rsoaresd]

Description

• add ban reason to NewBannedUser func

Issue ticket number and link

SANDBOX-681

Associated PRs:

• wa, pr 24
• SANDBOX-683: add ban reason kubesaw/ksctl#74

[codecov]

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 77.36%. Comparing base (d55d86f) to head (6fb53bc).
Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
pkg/cluster/service.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #427      +/-   ##
==========================================
+ Coverage   77.35%   77.36%   +0.01%     
==========================================
  Files          49       49              
  Lines        2009     2010       +1     
==========================================
+ Hits         1554     1555       +1     
  Misses        401      401              
  Partials       54       54              

Files with missing lines	Coverage Δ
pkg/banneduser/banneduser.go	100.00% <100.00%> (ø)
pkg/cluster/service.go	80.83% <0.00%> (ø)

[mfrancisc]

Nice 👍

[alexeykazakov]

Looks good.
But don't forget to check all the repos (host, member, e2e, reg-service, ksctl, sre) and update them if they use this API.

[ranakan19]

looks good, nothing more to add to existing feedback from alexey and francisc

[MatousJobanek]

But don't forget to check all the repos (host, member, e2e, reg-service, ksctl, sre) and update them if they use this API.

I think that we use this function in ksctl and workload-analyzer only

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[rsoaresd]

But don't forget to check all the repos (host, member, e2e, reg-service, ksctl, sre) and update them if they use this API.

I think that we use this function in ksctl and workload-analyzer only

Yes! :)