-
-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FGMRES refinement for Primal Dual System #773
Open
pghysels
wants to merge
21
commits into
coin-or:stable/3.14
Choose a base branch
from
pghysels:GMRESPDFull
base: stable/3.14
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add code for computing matrix Inf norm
…dmarsh condition, can worsen results.
I'm sorry, I didn't even run a |
I'm looking into the failed test with single precision |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the flexible generalized minimal residual method for refinement of the solution of the primal-dual system.
The main changes/additions in this PR are:
ComputeResidualRatio
method is modified to now compute the Infinity norm-wise relative backward error, which is used in the stopping criterion for FGMRES and iterative refinement.PDFullSpaceSolver::NrmInf
to compute the Inf-norm of the primal-dual system, which is used to compute the relative backward error.ComputeRowA1
andComputeColA1
inIpMatrix
to compute the 1-norm of the rows/columns in the matrix. This is implemented in the derived classes.PDFullSpaceSolver::ComputeResiduals
to use thealpha
andbeta
parameters so it can be used to compute a matrix vector product (or the residual).Our tests show improvements in convergence when using FGMRES compared to iterative refinement, for select problems, with minimal runtime overhead.
@bknueven @k1nshuk