Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Float32 and Float64 to Msg conversions #613

Merged
merged 2 commits into from
Oct 21, 2024
Merged

Add Float32 and Float64 to Msg conversions #613

merged 2 commits into from
Oct 21, 2024

Conversation

ramon54321
Copy link
Contributor

Small change to include Float32 and Float64 conversions in the Msg class. Currently there is no way to extract floats from Msg without a cast at the call site.

@ramon54321
Copy link
Contributor Author

ramon54321 commented Oct 21, 2024 •
edited
Loading

Hello, thank you for your consideration, how does this work, can this be merged?

@lihaoyi lihaoyi merged commit 626e7a4 into com-lihaoyi:main Oct 21, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ramon54321 @lihaoyi