loggerd: extract write_encode_data and eliminate recursion from handle_encoder_msg #33453
+68
−61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR has had no activity for 9 days. It will be automatically closed in 2 days if there is no activity. |
|
This PR has been automatically closed due to inactivity. Feel free to re-open once activity resumes. |
deanlee
force-pushed
the
loggerd_refactor
branch
from
0c3b360
to
9352d2f
Compare
|
This PR has had no activity for 9 days. It will be automatically closed in 2 days if there is no activity. |
|
This PR has been automatically closed due to inactivity. Feel free to re-open once activity resumes. |
|
This PR has had no activity for 9 days. It will be automatically closed in 2 days if there is no activity. |
deanlee
force-pushed
the
loggerd_refactor
branch
from
9352d2f
to
900b800
Compare
|
Can we break this up at all? |
deanlee
force-pushed
the
loggerd_refactor
branch
from
900b800
to
7488553
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
write_encode_data, improving code clarity and separation of concerns while preserving the existing writing behavior.handle_encoder_msgwith direct calls towrite_encode_datafor writing queued packets in the new segment. This change prevents potential crashes by handling queued packets safely, even if they are out of sync with the encoderd.service.nameparameter fromhandle_encoder_msg, as it duplicates there.publish_namevalue already available through thereparameter.Resolves #28857