replay: replace HttpRequest with libcurl for accessing comma API #33851
+213
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deanlee
force-pushed
the
replay_use_libcurl_with_comma_api
branch
2 times, most recently
from
947aa85
to
2973865
Compare
|
This PR has had no activity for 9 days. It will be automatically closed in 2 days if there is no activity. |
deanlee
force-pushed
the
replay_use_libcurl_with_comma_api
branch
from
2973865
to
05c9fc3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR eliminates the dependency on
self/ui/qt/apiby introducing a pure C++ version of the Comm API withintools/replay/api.Key Changes:
CommaApi2namespace to avoid conflicts with the existing Qt-based API.CommaApifunctions to remove Qt dependencies #33824, no modifications were made to the existing Qt-based API, ensuring that the UI remains unaffected by this change.Once the UI is fully migrated away from Qt, the CommaApi2 implementation can be moved to common library, enabling it to be shared across different modules.