Add support for overriding created_at timestamps for copy transform workflows #282
Conversation
Johnabell
force-pushed
the
support-created-at-override
branch
from
002e3e7
to
0bc9bef
Compare
Johnabell
force-pushed
the
support-created-at-override
branch
from
0bc9bef
to
fa9cb36
Compare
Johnabell
changed the title
There was a problem hiding this comment.
@Johnabell I see the reason for adding this feature and the code looks reasonable to me.
lib/event_store.ex
Outdated
| @@ -527,9 +527,16 @@ defmodule EventStore do | |||
| Snapshotter.delete_snapshot(conn, source_uuid, opts) | |||
| end | |||
|
|
|||
| @accepted_overrides [:created_at] | |||
There was a problem hiding this comment.
Perhaps created_at could be override_created_at to make the intent clear?
There was a problem hiding this comment.
What do you think about created_at_override, just a little concerned that override_created_at might sound more like something that expects a boolean?
There was a problem hiding this comment.
I have renamed it created_at_override, but happy rename it to your suggestion if you prefer.
…_to_stream function
Johnabell
force-pushed
the
support-created-at-override
branch
from
d87829f
to
705a8e2
Compare
| @@ -24,12 +24,17 @@ WITH | |||
| <% end %> | |||
| ), | |||
| stream AS ( | |||
| <%= if stream_id do %> | |||
| <%= cond do %> | |||
There was a problem hiding this comment.
This makes stream_id and created_at mutually exclusive. Not sure that that's a good idea?
There was a problem hiding this comment.
I couldn't think of a use case for both updating stream_version and the created_at. Do you think there is a reasonable use case for this? I am happy to update this file if you think we should support this.
We are looking at running a copy-transform on our event stream.
This involves reading all events out of one event store and filtering/transforming them before writing them to a new event store. To support this we would like to maintain the timestamps on the original events in both the events table and the streams table.
This PR make that possible by allowing the caller to override
created_atwhen appending events to the event store.