Remove `domain` prop in TokenProvider #803

gciotola · 2024-10-15T15:41:41Z

Closes commercelayer/issues-app#182

What I did

TokenProvider does not accept anymore domain prop.
Base API endpoint will be derived now from iss property present in access token.

Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests).
Make sure to add/update documentation regarding your changes.
You are NOT deprecating/removing a feature.

netlify · 2024-10-15T15:41:58Z

Name	Link
🔨 Latest commit	`3bae010`
🔍 Latest deploy log	https://app.netlify.com/sites/commercelayer-app-elements/deploys/67168e1676c82f00086ceab0
😎 Deploy Preview	https://deploy-preview-803--commercelayer-app-elements.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

…ss token iss

gciotola self-assigned this Oct 15, 2024

gciotola added breaking-change enhancement New feature or request labels Oct 15, 2024

gciotola requested a review from marcomontalbano October 15, 2024 15:41

gciotola requested a review from pfferrari October 15, 2024 15:42

gciotola force-pushed the domain-from-token-iss branch from 4893b50 to 395554b Compare October 17, 2024 11:51

gciotola marked this pull request as ready for review October 18, 2024 15:10

fix: remove domain prop in TokenProvider to derive endpoint from acce…

3bae010

…ss token iss

gciotola force-pushed the domain-from-token-iss branch from 395554b to 3bae010 Compare October 21, 2024 17:23

marcomontalbano approved these changes Oct 21, 2024

View reviewed changes