Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paper #195

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Paper #195

wants to merge 13 commits into from

Conversation

ntachukwu
Copy link
Contributor

JOSS paper issue #180

@codecov
Copy link

codecov bot commented Mar 17, 2022

Codecov Report

Merging #195 (9895486) into main (0e2aa9e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #195   +/-   ##
=======================================
  Coverage   94.78%   94.78%           
=======================================
  Files           3        3           
  Lines         728      728           
  Branches      216      216           
=======================================
  Hits          690      690           
  Misses         14       14           
  Partials       24       24           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e2aa9e...9895486. Read the comment docs.

Copy link
Member

@kinow kinow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a first go at reading the paper @Th3nn3ss , great work 👏

I can see the structure you wanted to give to the paper (in the same way you had to structure your presentation, and code for your PR, etc.) and got the idea of what you want to transmit to readers, I think.

You can probably ignore many of my comments, or use it as feedback but not necessarily as the best recommendation since I am not that well versed in academic writing (search for some sites about academic writing, you can probably find some useful information there.)

Cheers
Bruno

paper/paper.md Outdated Show resolved Hide resolved
paper/paper.md Outdated Show resolved Hide resolved
paper/paper.md Show resolved Hide resolved
paper/paper.md Outdated Show resolved Hide resolved
paper/paper.md Outdated Show resolved Hide resolved
paper/paper.md Outdated Show resolved Hide resolved
paper/paper.md Outdated Show resolved Hide resolved
paper/paper.md Outdated Show resolved Hide resolved
paper/paper.md Outdated Show resolved Hide resolved
paper/paper.md Outdated Show resolved Hide resolved
@ntachukwu ntachukwu requested a review from kinow March 23, 2022 07:33
Copy link
Member

@kinow kinow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Short and simple. Few comments, but I think this is ready for reviews @Th3nn3ss . Maybe mark as ready for review and ask the others to review it too? Thanks!!!

paper/paper.md Show resolved Hide resolved
paper/paper.md Outdated Show resolved Hide resolved
ntachukwu and others added 2 commits March 24, 2022 18:02
Co-authored-by: Bruno P. Kinoshita <kinow@users.noreply.github.com>
@ntachukwu ntachukwu marked this pull request as ready for review March 26, 2022 06:03
@kinow kinow requested review from mr-c, tetron and dinithiW March 26, 2022 09:43
paper/paper.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants