Add native_aarch64 install option #1267
Conversation
There was a problem hiding this comment.
I think it might be easier to support a --only=blah that generally fixes this for if: checks. We might not be able to use that for nightly as it's a bit hacky (though, maybe not?) but...seems like we'll end up with a lot of other matches if we're not careful if/when we support other platforms.
not blocking at all, don't want to stop forward progress, but thinking out loud here
| @@ -148,6 +148,7 @@ def squash_mount_check(rootfolder, subdir, context): | |||
| ) | |||
| @click.option("--enable", metavar="TYPE", multiple=True, help='Enable targets of type TYPE (e.g. "nightly")') | |||
| @click.option("--only-nightly", is_flag=True, help="Only install the nightly targets") | |||
| @click.option("--only-native-aarch64", is_flag=True, help="Only install the Native Aarch64 targets") | |||
There was a problem hiding this comment.
Sounds like we probably need a more general --only if we need to start adding lots of these.
| @@ -109,6 +109,9 @@ def should_install(self) -> bool: | |||
| if self.install_context.only_nightly and not self.nightly_like: | |||
| return False | |||
|
|
|||
| if self.install_context.only_native_aarch64 and self.config_get("if", "") != "native_aarch64": | |||
There was a problem hiding this comment.
Pragmatic, but I can't help wondering if a more general --only=native_aarch64 would be easier and more extensible. The nightly flag is special as we heuristically guess it rather than it being an actual if check in some cases
There was a problem hiding this comment.
--only=... is not possible, i have experimented with it, but it breaks all the dependency handling and whatnot
There was a problem hiding this comment.
wouldn't it be exactly the same as what you have there? Like..
if self.install_context.only and self.config_get("if", "") != self.install_context.only:There was a problem hiding this comment.
Ah I see that way, hmm, maybe. I experimented with making the filter do the work with narrowing the selection, but it's very hard to work with that code in general because the if information is not complete there like it is with config_get().
I'll give it a try
Way to install aarch64 binaries under amd64 (doesn't execute the version check)
bin/ce_install --enable native_aarch64 --only-native-aarch64 install ...Side-effect: will say things are already installed when they don't fall under the
if: native_aarch64without actually checking