[test] Skip the dictionary tests without a host toolchain - #61
Open
conrade-ctc wants to merge 1 commit into
Open
[test] Skip the dictionary tests without a host toolchain#61conrade-ctc wants to merge 1 commit into
conrade-ctc wants to merge 1 commit into
Conversation
setup_make runs make and a C++ compiler. A host with neither now skips the module instead of failing it. Only test03_add_library_path loads a dictionary in test_basic_api. That test gets a skip marker, and the module makes the dictionary optional. Co-developed-with-the-help-of: Claude Code (Fable 5, human in the loop)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a host with no make and no C++ compiler, every module that builds a test dictionary errors out in setup_make:
This is a follow-up to #51. setup_make now checks for make and for make's $(CXX) first, and skips the module with a clear reason. A build system that sets CPPJIT_TEST_SKIP_MAKE is unaffected. In test_basic_api only test03_add_library_path loads a dictionary, so it gets a skip marker and the other API tests keep running.