-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Java error in version 2.0.0 #428
Comments
Hi Chris, This looks more like a Java stability issue than an issue within the PeptideShaker code? We've been using Java 14 for some time and have not come across similar issues there. Is the error reproducible or did it only happen this one time? Best regards, |
Hi Harald, I moved to Java 14 and don't see the issue anymore. Cheers, |
Great! Thanks for the update! I will then close the issue and we can hope that a more stable Java 15 (or newer) will become available in the future. |
Same problem for different PeptideShaker version (e.g. 2.0.15 and 2.0.30) and OpenJDK java versions 11.0.9.1-internal and 1.8.0_292. I got this problem initially in the latest conda packages of PeptideShaker and then tried the manually installed versions on the same Linux machine. @hbarsnes Any idea of how to avoid this error? |
@veitveit Any chance you can update to Java 14 or 15 as well? (Java 16 has some other issues at the moment...) |
Sorry, I got a similar error with Java 15 (openjdk version "15.0.2" 2021-01-19)
|
@veitveit Given that Java 14 seemed to work for Chris, maybe you can give that version a go as well? |
@hbarsnes And here it, seems to be the same problem:
|
@veitveit Can you try giving PeptideShaker more memory to work with? In other words, adding the -Xmx option to your command line? |
@hbarsnes No change with -Xmx32G. I will try now with 50GB but have my doubts that is will go through. |
@veitveit Yes, the exports all work fine on my side. Hence the problem of how to debug the issue... |
@hbarsnes I am trying it with java 14 on another machine now.
I additionally installed this conda environment on a docker image, but this might not be necessary |
Update: same failure on another linux machine Odd situation that I don't manage to make it work and you always :-D
|
@veitveit Maybe the reason is that I only tested the exports with the example dataset so far. I can try with your data as well, but then I would need your FASTA and spectrum files too. |
@hbarsnes Thank you! |
@veitveit I can confirm that I get the same Java error for this particular data set as well. I will try to dig deeper and see what I can find. Might be a bit tricky as the error seems to occur inside SQLite though... |
@veitveit Quick update: We've now released a new version of PeptideShaker that also works on Java 16, but sadly upgrading to Java 16 does not make any difference on my end. But perhaps you can give it another go on your setup with Java 16 anyway? |
@hbarsnes Great that PeptideShaker now also works with Java 16. I also get still the same error. |
@veitveit Ah, that's too bad. But not unexpected of course. I guess we'll just have to wait for Java 17 then..? ;) |
Could the problem come from the version of the sqlite-jdbc library? There are much newer ones than version 3.18. And my experience is that java libraries are not really a gem of compatibility |
@veitveit I assumed that we were using the latest version of the sqlite-jdbc library, but if that is indeed not the case I will try updating and get back to you. |
@veitveit Updating to the most recent version of the sqlite-jdbc library does not seem to make a difference. However, the export works fine if done from the GUI instead of from the command line. And the resulting export from the GUI has the same file size and the same number of rows (with just the order of a couple of lines being switched) as the one from the command line that ends in the fatal Java error. I think we can therefore conclude that the export (at least in this case) has completed before the Java error occurs, but I will have to investigate this further. |
@veitveit Just noticed that the Java error is also there when exporting via the GUI as well. It is just not highlighted in the same way (as it is basically just written to the same folder as we jar file). So at least the error is consistent... |
@hbarsnes Let's say I am not interested too much in the error. Is there a way to find out whether the output file is actually complete? |
@veitveit I was trying to look into that. Given that the export in the GUI completes successfully, and the error only occurs afterwards, I think the output file is complete. But whether the data in the database has been corrupted along the way and thus affecting the output I cannot be sure. I do not think so though, as then there ought to have been "normal" Java exceptions in our own code when extracting the information. |
Hi,
I am seeing an error in PeptideShaker 2.0.0.
PeptideShaker seems to finish fine and then Reports is triggered to output the Certificate of Analysis and the Default PSM Report, which is when this error is triggered. But, it seems to actually write the reports OK as far as I can tell, although I am not entirely sure if it writes the entire PSM report (this gets export second).
Let me know if you need more information.
Thanks,
Chris
The text was updated successfully, but these errors were encountered: