Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add azure windows runner for pytorch #14

Merged
merged 5 commits into from
Jun 20, 2024

Conversation

aktech
Copy link
Contributor

@aktech aktech commented Jun 20, 2024

This adds a new configuration for windows runner for pytorch-cpu-feedstock.

Relevant issues:

cc @jaimergp @isuruf

@wolfv @baszalmstra can you confirm the following:

  • This is only for pytorch feedstock (as in only sponsoring windows runners for pytorch?)
  • Runner machine size (Standard_D2s_v3) is sufficient, i.e. 2 cores 8 GB RAM or need a larger runner (update: 8 cores and 32GB RAM now)

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@wolfv
Copy link
Member

wolfv commented Jun 20, 2024

Hey @aktech - we are happy with sponsoring a larger Windows runner also for other feedstocks but the immediate need was for pytorch, indeed. E.g. Tensorflow or other feedstocks should ideally also benefit 🚀

I think something with 4- or 8 cores would be more fun, no? :)

Thanks for pushing this through!

@aktech
Copy link
Contributor Author

aktech commented Jun 20, 2024

I think something with 4- or 8 cores would be more fun, no? :)

Sure, bumped to Standard_D8s_v3 8 cores and 32GB RAM. (I wasn't sure of the quota, but looks like the account has enough quota to support this)

@jaimergp
Copy link
Member

LGTM! Thanks for the work @aktech, and the generosity @wolfv.

I guess we would just need to leave in writing what the process is for other feedstocks to request access to the Windows resource. Pinging you here? Something in admin-requests?

@aktech aktech marked this pull request as ready for review June 20, 2024 09:00
@wolfv wolfv merged commit b2aeabf into conda-forge:master Jun 20, 2024
@wolfv
Copy link
Member

wolfv commented Jun 20, 2024

@aktech any steps that I need to do to get it running in this PR? conda-forge/pytorch-cpu-feedstock#231

@aktech aktech deleted the cirun-azure-pytorch branch June 21, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants