-
-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Close CUDA 12 migration (redux) #6263
Conversation
Revert "don't close CUDA 12.0 migration just yet" This reverts commit 688ab0d.
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Ping @jakirkham; I'd like to close this and then start discussing about a CUDA 12.4 or 12.6 migration (some packages already need newer versions than 12.0). I think we're ready here (and have been for quite a while), but since you invested so much time & energy on this migration I don't want to move forward without your input. |
Hey Axel, sorry for the slow reply here Axel and I discussed this offline after the last conda-forge meeting as we didn't get to this item in the meeting Generally we agreed that the CUDA 12.0 migration has reached completion. There were few points I suggested we work on:
According to the status page 98% of PRs are made. Only 12 PRs remain open. With all of the work done above (thank you Axel for your hard work! 🙏), think we can safely declare this done |
Thanks Axel! 🙏 |
Am noticing an issue with Axel, could you please take a quick look to make sure we are not missing anything here? |
@@ -7,6 +7,7 @@ c_compiler_version: # [unix] | |||
- 12 # [linux] | |||
- 16 # [osx] | |||
- 11 # [os.environ.get("CF_CUDA_ENABLED", "False") == "True" and linux] | |||
- 12 # [os.environ.get("CF_CUDA_ENABLED", "false") == "true" and linux] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries. Thanks Axel! 🙏
Since #5613 has been languishing for a while despite being essentially ready (aside from some open review requests to drop CUDA 12.4), let's actually get this over the finish line.
I made another clean-up push for the respective outstanding feedstocks. Below is the full list, but in any case, we already established that things are ready in #5613, so this just moves the needle even further into the "let's pull the trigger" area.
Closes #5390
Closes conda-forge/conda-forge.github.io#1963
Actively worked on
Stagnant
Blocked upstream
Dead feedstocks
libtvm
)