Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close CUDA 12 migration (redux) #6263

Merged
merged 1 commit into from
Sep 1, 2024
Merged

Conversation

h-vetinari
Copy link
Member

@h-vetinari h-vetinari commented Aug 9, 2024

Since #5613 has been languishing for a while despite being essentially ready (aside from some open review requests to drop CUDA 12.4), let's actually get this over the finish line.

I made another clean-up push for the respective outstanding feedstocks. Below is the full list, but in any case, we already established that things are ready in #5613, so this just moves the needle even further into the "let's pull the trigger" area.

Closes #5390
Closes conda-forge/conda-forge.github.io#1963

Actively worked on

Stagnant

Blocked upstream

Dead feedstocks

Revert "don't close CUDA 12.0 migration just yet"

This reverts commit 688ab0d.
@h-vetinari h-vetinari requested a review from a team as a code owner August 9, 2024 07:42
@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@h-vetinari h-vetinari mentioned this pull request Aug 9, 2024
5 tasks
@h-vetinari
Copy link
Member Author

Ping @jakirkham; I'd like to close this and then start discussing about a CUDA 12.4 or 12.6 migration (some packages already need newer versions than 12.0). I think we're ready here (and have been for quite a while), but since you invested so much time & energy on this migration I don't want to move forward without your input.

@jakirkham
Copy link
Member

Hey Axel, sorry for the slow reply here

Axel and I discussed this offline after the last conda-forge meeting as we didn't get to this item in the meeting

Generally we agreed that the CUDA 12.0 migration has reached completion. There were few points I suggested we work on:

  1. Try to get PRs close to completion through
    1. As CUDA 12 breaks the packaging format relative to CUDA 11 or earlier, thought we should try and get as many feedstocks on the other side of that break as possible
    2. Over the past few weeks Axel and I have made a best effort at this. The remainder are either unmaintained or will require substantial upstream work to adopt. So this is done
  2. Clean up migrator vendoring needed to workaround bugs seen in pybind11 using feedstocks
    1. The combination of CUDA 12.0 + GCC 12 + pybind11 was problematic. We found rolling back to GCC 11 worked around these issues. So vendored migrators in feedstocks to use the older GCC
    2. Since then pybind11 included a fix in 2.12.0, which addressed this issue
    3. Have worked with maintainers to clean these up anywhere they remained. More context in comment: Close CUDA 11.8 migration #5340 (comment)
    4. So this is also done
  3. Try to clear awaiting parents
    1. This isn't a hard blocker, but same as 1 we wanted to get this reasonably closed out due to the breaking nature of CUDA 12
    2. There are only 2 feedstocks without PRs. One appears unmaintained (like its parent). The other has an error as the feedstock is unmaintained and has fallen far behind
    3. In other words this is done

According to the status page 98% of PRs are made. Only 12 PRs remain open. With all of the work done above (thank you Axel for your hard work! 🙏), think we can safely declare this done

@jakirkham jakirkham merged commit 3f4332d into conda-forge:main Sep 1, 2024
4 checks passed
@jakirkham
Copy link
Member

Thanks Axel! 🙏

@h-vetinari h-vetinari deleted the cuda_12 branch September 1, 2024 02:03
@jakirkham
Copy link
Member

Am noticing an issue with zip_keys: conda-forge/ucx-split-feedstock#195 (comment)

Axel, could you please take a quick look to make sure we are not missing anything here?

@@ -7,6 +7,7 @@ c_compiler_version: # [unix]
- 12 # [linux]
- 16 # [osx]
- 11 # [os.environ.get("CF_CUDA_ENABLED", "False") == "True" and linux]
- 12 # [os.environ.get("CF_CUDA_ENABLED", "false") == "true" and linux]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I overlooked one of the places when taking over 1cf8857 where you had put in lower-case booleans, sorry.

Fixed in 23be5a0

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries. Thanks Axel! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CUDA 12 version in cbc.yaml - plans? conda-forge: CUDA 12 / new CUDA SDK bringup
2 participants