Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop outdated sysroot #147

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

h-vetinari
Copy link
Member

Something I descoped from #142 because AFAICT we either need to rebuild the sysroot-with-crypt for 2.17 without the track_features (here's a branch how this would look like; consists of rebasing v2.17 on the last commit before crypt-removal), or we'd need to do something like conda-forge/linux-sysroot-feedstock#68

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@h-vetinari
Copy link
Member Author

@isuruf, can you let me know how you'd like to proceed here? should I create a branch for the crypt stuff on the sysroot feedstock, or do you want to got the "get rid of the repodata hacks" route? (obviously doing the former doesn't rule out doing the latter later).

@h-vetinari
Copy link
Member Author

@isuruf, given that we'll have to wait several more months at least to get rid of the sysroot hacks, would you be OK with me creating a v2.17_crypt branch in the sysroot feedstock (details in OP)?

@h-vetinari
Copy link
Member Author

Ping @isuruf for how to proceed here.

@isuruf
Copy link
Member

isuruf commented Oct 6, 2024

Let's create 2.17 packages with crypt in it.

@isuruf
Copy link
Member

isuruf commented Oct 6, 2024

Can you send a PR to linux-sysroot-feedstock?

@h-vetinari
Copy link
Member Author

I can, but it needs a new branch before the crypt removal (which would go well with the label we're already using). I can create it if you want.

@isuruf
Copy link
Member

isuruf commented Oct 6, 2024

Can you send a PR against 2.17 branch? I can merge directly to a new merge.

@h-vetinari
Copy link
Member Author

h-vetinari commented Oct 6, 2024

The 2.17 branch has advanced too far. We should branch off earlier. Take a look at the branch I've already created (on my own fork) that's linked in the OP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants