Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure Windows builds #2

Merged
merged 13 commits into from
Oct 9, 2023
Merged

Configure Windows builds #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
a934226
dummy commit for rerendering
conda-forge-webservices[bot] Apr 13, 2023
01ef105
MNT: Re-rendered with conda-build 3.24.0, conda-smithy 3.23.1, and co…
Apr 13, 2023
d253969
Drop `win` from `skip`
jakirkham Apr 13, 2023
935a560
MNT: Re-rendered with conda-build 3.24.0, conda-smithy 3.23.1, and co…
Apr 13, 2023
fc454d1
Store artifacts on Azure (for debugging)
jakirkham Apr 13, 2023
e8c7747
MNT: Re-rendered with conda-build 3.24.0, conda-smithy 3.23.1, and co…
Apr 13, 2023
e5e7dac
Ignore linkages to a few Windows system libraries
jakirkham Apr 13, 2023
3d8e92d
Merge branch 'main' into conda_forge_admin_1
adibbley Aug 24, 2023
9db705c
MNT: Re-rendered with conda-build 3.26.1, conda-smithy 3.24.1, and co…
Aug 24, 2023
40936af
Update meta.yaml
adibbley Aug 24, 2023
b009c8e
MNT: Re-rendered with conda-build 3.27.0, conda-smithy 3.27.1, and co…
Oct 9, 2023
f2ac609
Drop Azure artifact storage
jakirkham Oct 9, 2023
c18af58
MNT: Re-rendered with conda-build 3.27.0, conda-smithy 3.27.1, and co…
Oct 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions .azure-pipelines/azure-pipelines-linux.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

49 changes: 49 additions & 0 deletions .azure-pipelines/azure-pipelines-win.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 10 additions & 0 deletions .ci_support/win_64_.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
c_compiler:
- vs2019
channel_sources:
- conda-forge
channel_targets:
- conda-forge main
cxx_compiler:
- vs2019
target_platform:
- win-64
9 changes: 4 additions & 5 deletions .scripts/build_steps.sh
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions .scripts/logging_utils.sh
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

112 changes: 112 additions & 0 deletions .scripts/run_win_build.bat
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 9 additions & 0 deletions README.md
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion azure-pipelines.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 5 additions & 2 deletions recipe/meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,13 +25,16 @@ source:

build:
number: 6
skip: true # [osx or win]
skip: true # [osx]

outputs:
- name: cuda-cudart_{{ target_platform }}
build:
noarch: generic
binary_relocation: false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that we know it was patchelf causing issues, perhaps it's time to remove this workaround?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK the patchelf bug is not fixed: NixOS/patchelf#492

So no don't think we should be removing that

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it's not fixed (I am fully aware), but we marked 0.18.0 as broken (you did it 🙂) and there's no 0.18.1 yet. I'd assume we are safe for now, and be extra cautious when a new patchelf is out.

We can even go further and pin patchelf globally, which I was surprised to see not done yet. We should consider it given its high impact.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would rather not open us to unnecessary risk with patchelf. This keeps us protected

We explored that before ( conda-forge/conda-smithy#1737 ), but there wasn't a good option to pursue ( conda-forge/conda-smithy#1737 (comment) )

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant to add patchelf to conda-forge-pinning-feedstock, not conda-smithy. Is it not an option (and why)?

Copy link
Member

@jakirkham jakirkham Oct 10, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unclear on how that would help. conda-forge-pinning only affects dependencies in the requirements of recipes themselves

Not build tools like patchelf that are installed in base (before the recipe is seen). This would require changes to conda-smithy to work

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, John, I see. I think this is where it confused me.

I know for a fact that installing patchelf to host could help ignore the one installed by conda-smithy. But it requires the recipe maintainer to manually add patchelf to host, which is something awkward that we don't want.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And there would still be a patchelf installed in base that conda-build would use. IOW the problem would still be there

missing_dso_whitelist: # [win]
- "*/api-ms-win-core-libraryloader-*.dll" # [win]
- "*/api-ms-win-security-systemfunctions-*.dll" # [win]
files:
- targets/{{ target_name }}/lib/libcu*.so.* # [linux]
- Library\bin\cudart*.dll # [win]
Expand Down Expand Up @@ -63,7 +66,7 @@ outputs:
doc_url: https://docs.nvidia.com/cuda/index.html

- name: cuda-cudart
files:
files: # [linux]
- lib/libcu*.so.* # [linux]
requirements:
build:
Expand Down