Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary dependencies #7

Merged
merged 3 commits into from
Sep 1, 2024

Conversation

jeongseok-meta
Copy link
Contributor

@jeongseok-meta jeongseok-meta commented Sep 1, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@jeongseok-meta jeongseok-meta mentioned this pull request Sep 1, 2024
1 task
Copy link
Member

@h-vetinari h-vetinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fully revert #6, including the additions to host/run environments.

@jeongseok-meta
Copy link
Contributor Author

It seems the linux builds work without them, where I still don't know what's been changed as it failed without them before. Anyways, thank you for helping keep the package clean and nice to follow the convention!

@jeongseok-meta jeongseok-meta marked this pull request as ready for review September 1, 2024 03:45
@jeongseok-meta jeongseok-meta changed the title Fix ignoring libstdcxx-ng unnecessarily Remove unnecessary dependencies Sep 1, 2024
@h-vetinari
Copy link
Member

I still don't know what's been changed as it failed without them before.

There was a gap between the merge of conda-forge/ctng-compilers-feedstock#148 & conda-forge/ctng-compiler-activation-feedstock#126 during which it was possible to run into this problem, but only on feedstocks doing

error_overlinking: true

@jeongseok-meta
Copy link
Contributor Author

Ah, good to know. Thank you again for gatekeeping! Merging now!

@jeongseok-meta jeongseok-meta merged commit 94be4fc into conda-forge:main Sep 1, 2024
8 checks passed
@jeongseok-meta jeongseok-meta deleted the run_export branch September 1, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants