Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gz-rendering v7_7.3.1 #6

Merged
merged 7 commits into from
Apr 16, 2023

Conversation

regro-cf-autotick-bot
Copy link
Contributor

It is very likely that the current package version for this feedstock is out of date.

Checklist before merging this PR:

  • Dependencies have been updated if changed: see upstream
  • Tests have passed
  • Updated license if changed and license_file is packaged

Information about this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version.
  3. The bot will stop issuing PRs if more than 3 version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.
  4. If you want these PRs to be merged automatically, make an issue with @conda-forge-admin,please add bot automerge in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.
  5. If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

Pending Dependency Version Updates

Here is a list of all the pending dependency version updates for this repo. Please double check all dependencies before merging.

Name Upstream Version Current Version
gz-rendering 7_7.3.1 Anaconda-Server Badge

Dependency Analysis

Please note that this analysis is highly experimental. The aim here is to make maintenance easier by inspecting the package's dependencies. Importantly this analysis does not support optional dependencies, please double check those before making changes. If you do not want hinting of this kind ever please add bot: inspection: false to your conda-forge.yml. If you encounter issues with this feature please ping the bot team conda-forge/bot.

Analysis by source code inspection shows a discrepancy between it and the the package's stated requirements in the meta.yaml.

Packages found by source code inspection but not in the meta.yaml:

  • pyopengl

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/4698691807, please use this URL for debugging.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@traversaro
Copy link
Contributor

Error:

2023-04-14T10:36:15.4751819Z CMake Error at /home/conda/feedstock_root/build_artifacts/gz-rendering7_1681468301969/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeho/share/cmake/gz-cmake3/cmake3/GzConfigureBuild.cmake:73 (message):
2023-04-14T10:36:15.4752370Z   -- BUILD ERRORS: These must be resolved before compiling.
2023-04-14T10:36:15.4752618Z Call Stack (most recent call first):
2023-04-14T10:36:15.4752831Z   CMakeLists.txt:178 (gz_configure_build)
2023-04-14T10:36:15.4753084Z 
2023-04-14T10:36:15.4753204Z 
2023-04-14T10:36:15.4753947Z CMake Error at /home/conda/feedstock_root/build_artifacts/gz-rendering7_1681468301969/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeho/share/cmake/gz-cmake3/cmake3/GzConfigureBuild.cmake:75 (message):
2023-04-14T10:36:15.4754825Z   -- 	Missing dependency [OpenGL] (Components: OpenGL)
2023-04-14T10:36:15.4755069Z Call Stack (most recent call first):
2023-04-14T10:36:15.4755274Z   CMakeLists.txt:178 (gz_configure_build)
2023-04-14T10:36:15.4755391Z 
2023-04-14T10:36:15.4755481Z 
2023-04-14T10:36:15.4756360Z CMake Error at /home/conda/feedstock_root/build_artifacts/gz-rendering7_1681468301969/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeho/share/cmake/gz-cmake3/cmake3/GzConfigureBuild.cmake:77 (message):
2023-04-14T10:36:15.4756833Z   -- END BUILD ERRORS

Interestingly, this never happened before.

@traversaro
Copy link
Contributor

I reproduced the problem, and it does not seem related to the CMake version.

@traversaro
Copy link
Contributor

A simple find_package(OpenGL REQUIRED) works, so probably it is something specific of how ign-cmake looks for OpenGL.

@traversaro
Copy link
Contributor

After investigating a bit more, it seems that a way to fix the problem is to add the {{ cdt('libglvnd-devel') }} dependency on Linux.

@traversaro
Copy link
Contributor

traversaro commented Apr 16, 2023

After investigating a bit more, it seems that a way to fix the problem is to add the {{ cdt('libglvnd-devel') }} dependency on Linux.

Apparently that package is not avalable in centos6, see:

conda_build.exceptions.DependencyNeedsBuildingError: Unsatisfiable dependencies for platform linux-64: {MatchSpec("libglvnd-devel-cos6-x86_64")}

Probably I think it is fine to just update to centos7 here, as other key packages for the typical robotic users are on centos7 (see conda-forge/opencv-feedstock#346) and in general I think centos6 compatibility is just relevant for some specific niche HPC users that I do not think are users of this package, see conda-forge/conda-forge.github.io#1436, https://conda-forge.org/docs/user/announcements.html#centos-7-docker-images-are-now-the-default, robotology/robotology-superbuild#929 for the context.

@traversaro
Copy link
Contributor

@conda-forge-admin please rerender

@traversaro
Copy link
Contributor

I also reported the strange behaviour of FindOpenGL I found in https://gitlab.kitware.com/cmake/cmake/-/issues/24814 .

@traversaro
Copy link
Contributor

All this EGL-related changes were triggered by gazebosim/gz-rendering#840 .

@traversaro traversaro merged commit fdea150 into conda-forge:main Apr 16, 2023
@regro-cf-autotick-bot regro-cf-autotick-bot deleted the 7_7.3.1_hb96b7a branch April 16, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants