Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve ignore_run_exports, don't refer to -ng packages #18

Merged

Conversation

conda-forge-admin
Copy link
Contributor

@conda-forge-admin conda-forge-admin commented Aug 14, 2024

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found some lint.

Here's what I've got...

For recipe/meta.yaml:

@h-vetinari h-vetinari changed the title MNT: rerender improve ignore_run_exports, don't refer to -ng packages Aug 14, 2024
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@h-vetinari
Copy link
Member

PPC is going to fail on travis conda-forge/status#185; we could change this to cross-compilation, but given that the content of the package is essentially only CMake metadata, we could also just make this noarch: generic and just build it once? Thoughts @conda-forge/ldas-tools-cmake?

@duncanmmacleod
Copy link
Contributor

PPC is going to fail on travis conda-forge/status#185; we could change this to cross-compilation, but given that the content of the package is essentially only CMake metadata, we could also just make this noarch: generic and just build it once? Thoughts @conda-forge/ldas-tools-cmake?

@h-vetinari, I have made this noarch: generic but with separate builds for unix and Windows because the Windows files go into <prefix>\Library\; is that the best thing to do here?

@h-vetinari
Copy link
Member

I have made this noarch: generic but with separate builds for unix and Windows because the Windows files go into <prefix>\Library\; is that the best thing to do here?

That's a great point, and is exactly the right way to fix this IMO. 👍 from me.

@duncanmmacleod duncanmmacleod merged commit 0c6ab49 into conda-forge:main Aug 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@conda-forge-admin please rerender
3 participants