Enable ppc64le #29
Enable ppc64le #29
Conversation
|
@conda-forge-admin, please rerender |
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
…nda-forge-pinning 2024.10.02.13.37.37
|
@conda-forge-admin, please rerender |
…nda-forge-pinning 2024.10.02.13.37.37
|
@conda-forge-admin, please rerender |
…nda-forge-pinning 2024.10.02.13.37.37
| c_compiler: | ||
| - clang # [ppc64le] | ||
| c_compiler_version: | ||
| - 18 # [ppc64le] |
There was a problem hiding this comment.
I saw that the version must be specified (475c28f). I'm wondering if this could be automatically updated by conda-forge-admin.
Related: https://conda-forge.org/news/2024/04/30/clang-everywhere/
There was a problem hiding this comment.
The conda_build_config.yaml file is used to manually override or specify the compiler and its version. I followed the article you referred to (please see the summary) because the package failed to build with GCC.
There was a problem hiding this comment.
Also, could you add a comment with a link to related issues saying that we forced clang due to ICE in GCC?
There was a problem hiding this comment.
The
conda_build_config.yamlfile is used to manually override or specify the compiler and its version. I followed the article you referred to (please see the summary) because the package failed to build with GCC.
I know, I'm just asking whether we have to manually upgrade the compiler version in the future to be compatible with the pinned dependencies. It seems that the Clang toolchain hasn't been pinned yet and it might cause problems due to conflicting C++ std library versions.
Edit: I just checked the build and it seems it's linked with libstdcxx. That solves my problem!
There was a problem hiding this comment.
Hm, I'm not sure about pinning the Clang toolchain. Feel free to make any changes that make sense to you.
|
@conda-forge-admin, please rerender |
…nda-forge-pinning 2024.10.03.22.00.47
conda-forge.yml
Outdated
| @@ -1,6 +1,6 @@ | |||
| build_platform: | |||
| linux_aarch64: linux_64 | |||
| linux_ppc64le: linux_64 | |||
| linux_ppc64le: linux_ppc64le | |||
There was a problem hiding this comment.
did cross compiling really fail that hard?
There was a problem hiding this comment.
travis has been giving ALOT of problems.
There was a problem hiding this comment.
From what I see, it built fine with cross-compiling (https://github.com/conda-forge/libjxl-split-feedstock/runs/30992590715)
There was a problem hiding this comment.
it would be great if we could go back to cross compilation.
There was a problem hiding this comment.
I'll leave it to @sshockwave (or you as maintainer), just in case he made that change for a reason.
There was a problem hiding this comment.
Well just for your reference:
conda-forge/status#185
There was a problem hiding this comment.
Excuse me for that. I didn't know Travis CI had problems since the log looks fine and the default in the document is to build natively. I will revert to cross-compilation.
…nda-forge-pinning 2024.10.04.13.32.50
|
Hi! This is the friendly conda-forge automerge bot! I considered the following status checks when analyzing this PR:
Thus the PR was passing and merged! Have a great day! |
Attempt to enable ppc64le by using the Clang compiler, as it fails to build with GCC.
Resolves #20, #22, #28
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)