-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebuild for CUDA 12 #34
Rebuild for CUDA 12 #34
Conversation
…nda-forge-pinning 2023.05.31.22.15.24
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Failure on CUDA 12:
|
IIUC this is due to this detection logic librealsense-feedstock/recipe/build.sh Lines 10 to 28 in cbde5a8
In particular this line librealsense-feedstock/recipe/build.sh Line 16 in cbde5a8
This works in the CUDA 11 case as However in CUDA 12, typical conda-forge Docker images are used. The CTK is shipped as Conda packages ( conda-forge/staged-recipes#21382 ). So users can just list what packages they need. This allows greater customization and flexibility, but comes with the cost of some additional maintenance effort. More details and discussion in issue ( conda-forge/conda-forge.github.io#1963 ) In this case would suggest moving the logic above under a CUDA 11 branch. The CUDA 12+ case can just use Hope that helps. Happy to answer any other questions that come up |
Thanks @jakirkham ! As soon as I am on the laptop I will try your solution. |
Just for complete transparency, this was my first test with a CUDA-enabled build (see #19), so it is possible that I did something wrong and/or not necessary in the recipe. |
Ok, following @jakirkham suggestion seems to be working fine, with the advantage that the recipe can be drastically simplified once we drop CUDA 11 support. |
Hi! This is the friendly conda-forge automerge bot! I considered the following status checks when analyzing this PR:
Thus the PR was passing and merged! Have a great day! |
Thanks Silvio! 🙏 Glad this is moving in the direction of being simpler to maintain 😀 |
This PR has been triggered in an effort to update cuda120.
Notes and instructions for merging this PR:
Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.
If this PR was opened in error or needs to be updated please add the
bot-rerun
label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase@conda-forge-admin, please rerun bot
in a PR comment to have theconda-forge-admin
add it for you.This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/5140655335, please use this URL for debugging.