Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve ignore_run_exports, don't refer to -ng packages #31

Merged
merged 6 commits into from
Aug 25, 2024
Merged

improve ignore_run_exports, don't refer to -ng packages #31

merged 6 commits into from
Aug 25, 2024

Conversation

h-vetinari
Copy link
Member

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

isuruf
isuruf reviewed Aug 14, 2024
View reviewed changes
recipe/meta.yaml Outdated Show resolved Hide resolved
@h-vetinari @isuruf
ignore run-exports from cxx compilers on all platforms
cffab86 
Co-authored-by: Isuru Fernando <isuruf@gmail.com>
@h-vetinari
Copy link
Member Author

@conda-forge/libtool, this should be good to go, PTAL! :)

@h-vetinari
Copy link
Member Author

While I'm add it, I noticed today that libtool doesn't have a run-export. Should we add one?

@h-vetinari
Copy link
Member Author

Ping @conda-forge/libtool

@isuruf isuruf merged commit 56b0949 into conda-forge:main Aug 25, 2024
7 checks passed
@isuruf
Copy link
Member

isuruf commented Aug 25, 2024

Thanks

@h-vetinari h-vetinari deleted the no_ng branch August 26, 2024 02:39
@h-vetinari h-vetinari mentioned this pull request Aug 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isuruf isuruf isuruf left review comments

@jakirkham jakirkham Awaiting requested review from jakirkham jakirkham is a code owner

@mingwandroid mingwandroid Awaiting requested review from mingwandroid mingwandroid is a code owner

@msarahan msarahan Awaiting requested review from msarahan msarahan is a code owner

@ocefpaf ocefpaf Awaiting requested review from ocefpaf ocefpaf is a code owner

@saraedum saraedum Awaiting requested review from saraedum saraedum is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@h-vetinari @isuruf