-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bot-automerge] nccl v2.15.5-1 #80
[bot-automerge] nccl v2.15.5-1 #80
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Hi! This is the friendly conda-forge automerge bot! I considered the following status checks when analyzing this PR:
Thus the PR was not passing and not merged. |
@leofang, do you know what the conclusion was with issue ( #78 )? See this came up in comment ( #79 (review) ) Note: Stopped CI here so it doesn't automerge yet |
Hi @jakirkham I believe @cliffwoolley made a patch that's included since NCCL v2.15.1-1: NVIDIA/nccl@78313a6. But the lesson here is we should statically link cudart like all other CUDA libraries to avoid issues (sorry, can't find internal guideline for this, but this is standard practice 😅). We need to change Should we make the change in #79 and let it propagate to newer versions? |
IIRC there's some implications for some things related to the CUDA context related to dynamic vs static linking. I don't remember exactly what these implications are, but maybe you could ask around a bit internally @jakirkham? If there aren't any implications I don't see why we would differ from the standard conda-forge policy regarding static vs dynamic linking unless explicitly necessary. |
@kkraus14 @jakirkham Actually there is a public reference for this:
|
Sorry for the slow reply. Got caught up with other things. Not following why that means we need to statically link. It just seems to suggest there are users out there that choose to (and what happens in that case), which is a different thing. |
You're not required to statically link the CUDA Runtime (libcudart_static.a), but doing so has a number of advantages. Further, static linking to cudart is the default selection when nvcc is used for linking as well as the method used in all of NVIDIA's prebuilt binaries. |
Static linking in package management has several downsides:
This is covered in more detail in CFEP 18. As Keith noted above, unless there is a compelling reason (not seeing it yet), we should be using dynamic libraries here. |
John, what do you propose to fix #78? |
Also, this discussion is very odd to me. We only have this discussion as we choose to build NCCL here, instead of using the pre-built binary as done in all other NVIDIA-related feedstocks. I would prefer to pick one decision quickly and move on. There are a lot of other public challenges to discuss and pan out, and this is not on my list 😅 |
Sorry for the slow reply here As part of the CUDA 12 bringup work recently, we decided to use Given we are generally preferring linking |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please rerender |
Hi! This is the friendly conda-forge automerge bot! It appears that not all commits to this PR were made by the bot. Thus this PR is not being automatically merged. Please add the |
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub actions workflow run https://github.com/conda-forge/nccl-feedstock/actions/runs/4678170947. |
Merge and retry on main. |
Awesome! Thank you Leo for shepherding all of these in ❤️ |
All 11 packages are up on anaconda.org. |
It is very likely that the current package version for this feedstock is out of date.
Checklist before merging this PR:
license_file
is packagedInformation about this PR:
@conda-forge-admin,
please add bot automerge
in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.bot-rerun
label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase@conda-forge-admin, please rerun bot
in a PR comment to have theconda-forge-admin
add it for you.Closes: #79
Dependency Analysis
We couldn't run dependency analysis due to an internal error in the bot. :/ Help is very welcome!
This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/autotick-bot/actions/runs/3323807049, please use this URL for debugging.