-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
numpy v1.26.2 #305
numpy v1.26.2 #305
Conversation
…nda-forge-pinning 2023.11.13.03.32.18
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
It seems we're having problems with pip on all cross-compiled architectures:
|
For some reason |
@conda-forge-admin, please rerender |
…nda-forge-pinning 2023.11.19.09.00.44
This is an issue with |
Signed-off-by: Marcel Bargull <marcel.bargull@udo.edu>
@conda-forge-admin, please rerender |
1 similar comment
@conda-forge-admin, please rerender |
It's probably not rerendering due to https://www.githubstatus.com/incidents/x39xrr5m11b3 |
…nda-forge-pinning 2023.11.19.09.00.44 Signed-off-by: Marcel Bargull <marcel.bargull@udo.edu>
________________ ERROR at setup of test_is_timedelta64_object _________________
[gw0] win32 -- Python 3.9.18 %PREFIX%\python.exe
tmp_path = WindowsPath('C:/Users/VssAdministrator/AppData/Local/Temp/pytest-of-VssAdministrator/pytest-0/popen-gw0/test_is_timedelta64_object0')
@pytest.fixture
def install_temp(tmp_path):
# Based in part on test_cython from random.tests.test_extending
if IS_WASM:
pytest.skip("No subprocess")
srcdir = os.path.join(os.path.dirname(__file__), 'examples', 'cython')
build_dir = tmp_path / "build"
os.makedirs(build_dir, exist_ok=True)
try:
subprocess.check_call(["meson", "--version"])
except FileNotFoundError:
pytest.skip("No usable 'meson' found")
if sys.platform == "win32":
subprocess.check_call(["meson", "setup",
"--buildtype=release",
"--vsenv", str(srcdir)],
cwd=build_dir,
)
else:
subprocess.check_call(["meson", "setup", str(srcdir)],
cwd=build_dir
)
> subprocess.check_call(["meson", "compile", "-vv"], cwd=build_dir)
build_dir = WindowsPath('C:/Users/VssAdministrator/AppData/Local/Temp/pytest-of-VssAdministrator/pytest-0/popen-gw0/test_is_timedelta64_object0/build')
srcdir = 'D:\\bld\\numpy_1700564714692\\_test_env\\lib\\site-packages\\numpy\\core\\tests\\examples\\cython'
tmp_path = WindowsPath('C:/Users/VssAdministrator/AppData/Local/Temp/pytest-of-VssAdministrator/pytest-0/popen-gw0/test_is_timedelta64_object0')
..\_test_env\lib\site-packages\numpy\core\tests\test_cython.py:54:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
popenargs = (['meson', 'compile', '-vv'],)
kwargs = {'cwd': WindowsPath('C:/Users/VssAdministrator/AppData/Local/Temp/pytest-of-VssAdministrator/pytest-0/popen-gw0/test_is_timedelta64_object0/build')}
retcode = 2, cmd = ['meson', 'compile', '-vv']
def check_call(*popenargs, **kwargs):
"""Run command with arguments. Wait for command to complete. If
the exit code was zero then return, otherwise raise
CalledProcessError. The CalledProcessError object will have the
return code in the returncode attribute.
The arguments are the same as for the call function. Example:
check_call(["ls", "-l"])
"""
retcode = call(*popenargs, **kwargs)
if retcode:
cmd = kwargs.get("args")
if cmd is None:
cmd = popenargs[0]
> raise CalledProcessError(retcode, cmd)
E subprocess.CalledProcessError: Command '['meson', 'compile', '-vv']' returned non-zero exit status 2.
cmd = ['meson', 'compile', '-vv']
kwargs = {'cwd': WindowsPath('C:/Users/VssAdministrator/AppData/Local/Temp/pytest-of-VssAdministrator/pytest-0/popen-gw0/test_is_timedelta64_object0/build')}
popenargs = (['meson', 'compile', '-vv'],)
retcode = 2
..\_test_env\Lib\subprocess.py:373: CalledProcessError
---------------------------- Captured stdout setup ----------------------------
1.3.0
The Meson build system
Version: 1.3.0
Source dir: %PREFIX%\Lib\site-packages\numpy\core\tests\examples\cython
Build dir: C:\Users\VssAdministrator\AppData\Local\Temp\pytest-of-VssAdministrator\pytest-0\popen-gw0\test_is_timedelta64_object0\build
Build type: native build
Project name: checks
Project version: undefined
Activating VS 17.8.0
C compiler for the host machine: gcc (gcc 12.2.0 "gcc (x86_64-posix-seh-rev2, Built by MinGW-W64 project) 12.2.0")
C linker for the host machine: gcc ld.bfd 2.39
Cython compiler for the host machine: cython (cython 3.0.5)
Host machine cpu family: x86_64
Host machine cpu: x86_64
Program python3 found: YES (%PREFIX%\python.exe)
Run-time dependency python found: YES 3.9
Build targets in project: 1
checks undefined
User defined options
buildtype: release
vsenv : true
Found ninja-1.11.1 at %PREFIX%\Library\bin\ninja.EXE
Visual Studio environment is needed to run Ninja. It is recommended to use Meson wrapper:
%PREFIX%\Scripts\meson compile -C .
Activating VS 17.8.0
INFO: automatically activated MSVC compiler environment
INFO: autodetecting backend as ninja
INFO: calculating backend command to run: %PREFIX%\Library\bin\ninja.EXE -v
Traceback (most recent call last):
File "%PREFIX%\lib\site-packages\mesonbuild\mesonmain.py", line 194, in run
return options.run_func(options)
File "%PREFIX%\lib\site-packages\mesonbuild\mcompile.py", line 389, in run
p, *_ = mesonlib.Popen_safe(cmd, stdout=sys.stdout.buffer, stderr=sys.stderr.buffer, env=env)
AttributeError: 'NoneType' object has no attribute 'buffer'
ERROR: Unhandled python exception
This is a Meson bug and should be reported! (No idea why
(As always: If someone can run these tests natively, we could preclude emulation issues before looking further.) |
@mattip maybe you'd be able to run that PyPy on Windows test with Meson 1.3.0, or know why |
I have seen this before when running under pytest + pypy + windows. I don't remember where. I can try to reproduce locally, but maybe it would be prudent to skip these tests on PyPy. |
Thanks Matti. As for the |
conda-forge.yml
Outdated
# Use mambabuild to workaround https://github.com/conda-forge/conda-smithy/issues/1805 | ||
conda_build_tool: mambabuild |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not needed anymore after the last commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does that mean the cross-python
stuff injects itself by overwriting the host
's python
or something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, ok.
Would it be sensible to let it overwrite ${BUILD_PREFIX}/bin/pip
too (if it exists)?
(Yes, I know about the bonkers "we explicitly give you a pip
executable, but you should actually only ever use python -m pip
" thing people say and I don't agree for obvious reasons.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's rather continue to discuss that at conda-forge/cross-python-feedstock#76 .
The following in the win+pypy failures looks suspect:
Actually, we're currently not setting up a C-compiler for the tests on windows, so I guess that's why it picks up the gcc from the image. Perhaps something changed about how this detection is done in meson 1.3? Not sure though why this works on CPython. |
I've restarted the builds now that we have openblas 0.3.25 available (recalling that the switch from 0.3.23 to 0.3.24 surfaced the apparent emulation problems, it could have been that 0.3.25 changes behaviour again), but the result is the same. I guess we should try the QEMU update... |
I would expect this to show up upstream, but it seems that so far Numpy wheel CI runs with windows + pypy use meson 1.3.0 and pass tests. It is hard to see whether the tests that fail here pass there. |
This shouldn't be related to
Restarting the build with the new container images that have QEMU 8 |
ARM builds still failing as before.
(As always: If someone can run these tests natively, we could preclude emulation issues before looking further.) |
I think for numpy it's OK to skip two tests. The issue is larger in scipy where we have 60 apparently spurious failures... |
This reverts commit 457de92.
@conda-forge-admin, please rerender (just confirming that this doesn't cause further change; already verified locally) |
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub actions workflow run https://github.com/conda-forge/numpy-feedstock/actions/runs/6978161822. |
It is very likely that the current package version for this feedstock is out of date.
Checklist before merging this PR:
license_file
is packagedInformation about this PR:
@conda-forge-admin,
please add bot automerge
in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.bot-rerun
label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase@conda-forge-admin, please rerun bot
in a PR comment to have theconda-forge-admin
add it for you.Closes: #302
Dependency Analysis
Please note that this analysis is highly experimental. The aim here is to make maintenance easier by inspecting the package's dependencies. Importantly this analysis does not support optional dependencies, please double check those before making changes. If you do not want hinting of this kind ever please add
bot: inspection: false
to yourconda-forge.yml
. If you encounter issues with this feature please ping the bot teamconda-forge/bot
.Analysis by source code inspection shows a discrepancy between it and the the package's stated requirements in the meta.yaml.
Packages found by source code inspection but not in the meta.yaml:
This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/6845296584, please use this URL for debugging.