-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove version constraint of nvcc
to match with host cuda version
#87
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Not sure what you meant, isn't |
We still need this check for building the |
Synced offline with @leofang and agreed on erroring only during conda build time and just raising a warning for end-user during conda activation. |
Co-authored-by: jakirkham <jakirkham@gmail.com>
Co-authored-by: jakirkham <jakirkham@gmail.com>
Would also bump the build number here nvcc-feedstock/recipe/meta.yaml Line 2 in 4acf86c
That should generate new packages with this change |
Done 👍 |
Thanks Prem! 🙏 LGTM ✅ Will give others a chance to look 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @galipremsagar @jakirkham. LGTM.
@@ -65,8 +65,13 @@ fi | |||
|
|||
if [[ -z "\$(\${CUDA_HOME}/bin/nvcc --version | grep "Cuda compilation tools, release ${PKG_VERSION}")" ]] | |||
then | |||
echo "Version of installed CUDA didn't match package" | |||
return 1 | |||
if [[ "\${CONDA_BUILD}" = "1" ]] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to self: the extra backslash is needed because this is part of codegen, not the actual script.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be eliminated in #91.
Hi! This is the friendly conda-forge automerge bot! I considered the following status checks when analyzing this PR:
Thus the PR was passing and merged! Have a great day! |
Should we port this change to the Windows script? |
Seems reasonable |
This PR removes the version constraint that
nvcc
imposes to have the matching CUDA version on the host machine installed. Upon some searching, relaxing & testing this fix it appears that there is no version-specific file being shipped along withnvcc
conda package, but I could be wrong here too. Hence requesting review from maintainers since this check has been present since its inception.Rationale behind this PR is to allow users to utilized any version of
nvcc
package without upgrading their local host CUDA installations.Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)