Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild for CUDA 12 #16

Conversation

regro-cf-autotick-bot
Copy link
Contributor

This PR has been triggered in an effort to update cuda120.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/5147871339, please use this URL for debugging.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jakirkham
Copy link
Member

Seeing the following error on CI:

      Please set them or make sure they are set and tested correctly in the CMake files:
      CUDA_cufft_LIBRARY (ADVANCED)
          linked by target "backend" in directory /home/conda/feedstock_root/build_artifacts/nyxus_1685645514903/work

As the new CUDA 12 packages split all these components up ( conda-forge/staged-recipes#21382 ), think we need to add libcufft-dev to host:

  host:
    - libcufft-dev      # [(cuda_compiler_version or "").startswith("12")]

Note that *-dev suffixed packages have headers and dynamic libraries. They add the * package (no -dev suffix) to run automatically via run_exports

Edit: For more info about the CUDA 12 bringup, please see issue ( conda-forge/conda-forge.github.io#1963 )

@sameeul
Copy link
Contributor

sameeul commented Jun 5, 2023

I am getting this following error, however I do not get this if I build it in my local machine with CUDA 12.

2023-06-05T14:56:27.3765941Z       /home/conda/feedstock_root/build_artifacts/nyxus_1685976803221/work/src/nyx/gpu/gpu.h:2:10: fatal error: cufft.h: No such file or directory
2023-06-05T14:56:27.3766168Z           2 | #include <cufft.h>
2023-06-05T14:56:27.3766330Z             |          ^~~~~~~~~
2023-06-05T14:56:27.3766470Z       compilation terminated.

Any idea how to address this?

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict.
Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

@jakirkham
Copy link
Member

Hi Sameeul 👋

Think the latest change looks good (was about to suggest something similar)

Though it appears there are some conflicts that surfaced? Can take another look when those are resolved and CI has run again

@sameeul
Copy link
Contributor

sameeul commented Jun 5, 2023

conda-forge-admin, please rerun bot

@jakirkham jakirkham added the bot-rerun Instruct the bot to retry the PR label Jun 5, 2023
@jakirkham
Copy link
Member

Think an @ is needed before the user name. In any event, went ahead and added the label to rerun (assuming that was what was intended). Though please feel free to remove the label if I misunderstood

@regro-cf-autotick-bot
Copy link
Contributor Author

Due to the bot-rerun label I'm closing this PR. I will make another one as appropriate. This was generated by https://github.com/regro/cf-scripts/actions/runs/5180977863

@regro-cf-autotick-bot regro-cf-autotick-bot deleted the rebuild-cuda120-0-1_hd32abe branch June 5, 2023 19:15
@sameeul
Copy link
Contributor

sameeul commented Jun 5, 2023

Not sure why bot-rerun is generating a new PR. Any way to manually trigger it?

@jakirkham
Copy link
Member

jakirkham commented Jun 5, 2023

New bot PRs are generated by a cron job that runs at ~6hr intervals. So this is expected

One could create a new PR that adds the cuda120 migrator manually. This is effectively what the bot does. Re-rendering will pull in the migration changes to CI, etc.. Then bump the build/number

@jakirkham
Copy link
Member

Looks like the bot opened PR ( #18 ) after our discussion

@sameeul
Copy link
Contributor

sameeul commented Jun 6, 2023

Yup, I am still having the missing "cufft.h" issue. Unable to reproduce in my local environment :-(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot-rerun Instruct the bot to retry the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants