Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to 1.10.16 #125

Merged
merged 4 commits into from
Jun 18, 2024
Merged

Bump to 1.10.16 #125

merged 4 commits into from
Jun 18, 2024

Conversation

jaimergp
Copy link
Member

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

@jaimergp
Copy link
Member Author

@conda-forge-admin, please rerender

@pavelzw pavelzw added the automerge Merge the PR when CI passes label Jun 18, 2024
@pavelzw
Copy link
Member

pavelzw commented Jun 18, 2024

@ytausch do you know why the autotickbot doesn't work here?

@jaimergp
Copy link
Member Author

jaimergp commented Jun 18, 2024

I think we need to add the 1.x branch in the conda-forge.yml. Let me put it here.

edit: nvm, that goes in main not here, and it's only for abi migrations, not version updates.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jaimergp
Copy link
Member Author

@conda-forge-admin, please rerender

@github-actions github-actions bot removed the automerge Merge the PR when CI passes label Jun 18, 2024
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

Commits were made to this PR after the automerge label was added. For security reasons, I have disabled automerge by removing the automerge label. Please add the automerge label again (or ask a maintainer to do so) if you'd like to enable automerge again!

@pavelzw
Copy link
Member

pavelzw commented Jun 18, 2024

ahh, that's the reason 👍🏻

@pavelzw pavelzw added the automerge Merge the PR when CI passes label Jun 18, 2024
@github-actions github-actions bot removed the automerge Merge the PR when CI passes label Jun 18, 2024
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

Commits were made to this PR after the automerge label was added. For security reasons, I have disabled automerge by removing the automerge label. Please add the automerge label again (or ask a maintainer to do so) if you'd like to enable automerge again!

@pavelzw pavelzw added the automerge Merge the PR when CI passes label Jun 18, 2024
@github-actions github-actions bot merged commit 806dc4d into conda-forge:1.x Jun 18, 2024
37 checks passed
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

@jaimergp
Copy link
Member Author

Thanks @pavelzw. Also check conda-forge/conda-forge-repodata-patches-feedstock#779 to cover the previous versions.

@ytausch
Copy link

ytausch commented Jun 25, 2024

@ytausch do you know why the autotickbot doesn't work here?

As far as I understand, it's an inherent limitation of the bot that it can track one version per feedstock repository (not even output!) only. If there is 2.x, it is impossible for the bot to make PRs for new 1.x releases. Improving this is on my roadmap.

@ytausch
Copy link

ytausch commented Jun 25, 2024

XRef: regro/cf-scripts#2700

This was referenced Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants