-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ray 1.4.1 #28
Ray 1.4.1 #28
Changes from 9 commits
c65c000
f356865
59f28c8
440a2ff
a50fbf4
ed2ea02
fbb74dc
7ca68ba
0ad6110
b4111ef
c4d81d8
ce86c2b
28a2855
0e9a7ea
9b99dcd
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,6 +8,10 @@ curl: | |
- '7' | ||
cxx_compiler: | ||
- vs2017 | ||
nodejs: | ||
- '12' | ||
- '14' | ||
- '15' | ||
pin_run_as_build: | ||
curl: | ||
max_pin: x | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,6 +8,10 @@ curl: | |
- '7' | ||
cxx_compiler: | ||
- vs2017 | ||
nodejs: | ||
- '12' | ||
- '14' | ||
- '15' | ||
pin_run_as_build: | ||
curl: | ||
max_pin: x | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,6 +8,10 @@ curl: | |
- '7' | ||
cxx_compiler: | ||
- vs2017 | ||
nodejs: | ||
- '12' | ||
- '14' | ||
- '15' | ||
pin_run_as_build: | ||
curl: | ||
max_pin: x | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,6 +8,10 @@ curl: | |
- '7' | ||
cxx_compiler: | ||
- vs2017 | ||
nodejs: | ||
- '12' | ||
- '14' | ||
- '15' | ||
pin_run_as_build: | ||
curl: | ||
max_pin: x | ||
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
cuda_compiler_version: # [linux64] | ||
- None # [linux64] | ||
docker_image: # [linux64] | ||
- quay.io/condaforge/linux-anvil-cos7-x86_64 # [linux64] | ||
cudnn: # [linux64] | ||
- undefined # [linux64] | ||
cdt_name: # [linux64] | ||
- cos7 # [linux64] |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,12 @@ | ||
{% set version = "1.4.0" %} | ||
{% set version = "1.4.1" %} | ||
|
||
package: | ||
name: ray-packages | ||
version: {{ version }} | ||
|
||
source: | ||
url: https://github.com/ray-project/ray/archive/ray-{{ version }}.tar.gz | ||
sha256: 1ad04845dad6824220ad7750d666e7186f6b9186fb99294aae7d0e35f8e75018 | ||
sha256: a5fcaeb405fc9e6ddf084d55d202f72c919e974dac736d0426a8b569f7022e4a | ||
patches: | ||
- patches/0001-Do-not-force-pickle5-in-sys.path.patch | ||
- patches/0002-Fix-redis-build-for-non-default-compiler-drivers.patch | ||
|
@@ -18,9 +18,9 @@ source: | |
- patches/0008-Add-workaround-for-os.path.isdir-on-Windows.patch | ||
- patches/0009-Include-process.h-for-getpid-explicitly-on-Windows.patch | ||
- patches/0010-Empty-install-requirements-installed-by-conda-build.patch | ||
- patches/0011-permit-python-3.9.patch | ||
- patches/0012-Ignore-warnings-in-event.cc-and-logging.cc.patch | ||
- patches/0013-Disable-runfiles-on-windows.patch | ||
- patches/0011-Ignore-warnings-in-event.cc-and-logging.cc.patch | ||
- patches/0012-Disable-runfiles-on-windows.patch | ||
- patches/0013-Add-bazel-linkopts-libs.patch | ||
|
||
|
||
build: | ||
|
@@ -71,6 +71,7 @@ outputs: | |
- {{ compiler('cxx') }} | ||
- bazel <=3.4.1 # [not win] | ||
- bazel <3.7 # [win] | ||
- sysroot_linux-64 2.17 # [linux64] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. if we update the base to There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's necessary so that this package gets the correct run-export (so that packages depending on ray fail to build if they don't have cos7 themselves), otherwise we might get crashes with the ABI. |
||
- curl | ||
- cython >=0.29 | ||
- make | ||
|
@@ -305,3 +306,4 @@ extra: | |
- dHannasch | ||
- h-vetinari | ||
- vnlitvinov | ||
- krfricke | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. welcome on board! 🙃 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks 😄 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Agreed, already mentioned that on the last PR - happy to have you on board! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so there is no way to stay on
cos6
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, we cannot, see this comment, specifically:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But we can use older
nodejs
, e.g. one from14.x
version part, which is still in "active" phase according to their schedule and works oncos6
:)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, this comment didn't show up in the main thread for some reason.
I'm strongly against pinning to old versions for the sake of EOL distros.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you feel so strongly about cos6-support, we can add a branch where nodejs is pinned to 14.x, but master must move on. (though this would need some care with the build numbers; e.g. build numbers on master start from 100)