-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add librerun-sdk output for the C++ library #30
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe:
|
@conda-forge-admin, please rerender |
…nda-forge-pinning 2024.03.02.14.00.21
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe:
|
@conda-forge-admin, please rerender |
…nda-forge-pinning 2024.03.02.16.06.49
Ok, Linux is passing, while macOS and Windows are failing but with errors that are easy to deal with. However, there is currently a bigger problem. As the two different outputs of the recipe depends on distinct dependencies that have multiple pinned version ( At this point, as I have no idea how to change this behavior, I guess it make sense to package the C++ version as its own feedstock, given that anyhow the compilation of the rust part is not shared? |
Do you(@traversaro) know how conda-smithy reacts to multiple feedstocks on one source release? Does it just trigger a rerender on all of them? |
I guess so, but to be honest it is just an intuition and I do not remember an example of that. |
Ahh yeah, that matrix explosion is unfortunate. In general does the build actually need to be parameterized by python version? For pypi I know we only build a single wheel with |
I think there have been discussion in that direction (see conda-forge/conda-forge.github.io#1865 and conda-forge/python-feedstock#669), but I am afraid conda-forge tooling at the moment is still not working for that, but I may be wrong. |
Ok, I opened a PR for adding this as a new feedstock, see conda-forge/staged-recipes#25648 . Let's close this. |
Yes. LLVM is split over at least 8 feedstocks, and they all get a PR when a new version is released |
Great, thanks! |
Fix #18 . Work in progress. I am not totally sold on the name of the package, as typically the scheme in conda-forge is
lib<name>
for the C/C++ backend, and then<name>
or<name>-python
for the python bindings, while in this case both the C++ and Python packages are actually bindings of the Rust library.Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)