Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding quad-precision build support #9

Merged
merged 11 commits into from
Aug 22, 2024

Conversation

SwayamInSync
Copy link
Contributor

This PR adds quad-precision support to the SLEEF conda-forge package. The changes enable the building and packaging of the quad-precision library (libsleefquad) alongside the existing SLEEF libraries.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found some lint.

Here's what I've got...

For recipe/meta.yaml:

  • There are too few lines. There should be one empty line at the end of the file.
  • This recipe is using a compiler, which now requires adding a build dependence on {{ stdlib("c") }} as well. Note that this rule applies to each output of the recipe using a compiler. For further details, please see META: {{ stdlib("c") }} migration conda-forge.github.io#2102.

@SwayamInSync
Copy link
Contributor Author

PR regarding issue #8

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found some lint.

Here's what I've got...

For recipe/meta.yaml:

  • There are too few lines. There should be one empty line at the end of the file.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@SwayamInSync
Copy link
Contributor Author

@bluescarni any thoughts on why the windows and Travis CI are failing?

@bluescarni
Copy link
Contributor

@SwayamInSync for the PPC64 build failure, I recall reading on the conda-forge gitter channel that there were issues with travis and that the solution was to switch to cross compilation from x86. Pinging the great @h-vetinari to see if they can assist as I my conda-forge-fu is not that strong.

For the Windows build I don't really know...

recipe/meta.yaml Outdated
- {{ stdlib("c") }}
- cmake
- ninja # [unix]
- make # [unix]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SwayamInSync I was wondering why is make needed here, as the recipe on Unix uses ninja as generator?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching that, make sense, I would've just put that there for my local use, will push a refactor commit for this

@h-vetinari
Copy link
Member

Pinging the great @h-vetinari to see if they can assist as I my conda-forge-fu is not that strong.

Thanks for the flattery, but "stubborn" might be more accurate than "great". 😅

In any case, PPC is going to run into conda-forge/status#185. Since you're already cross-compiling osx-arm64, the hope would be that you could switch to cross-compilation also for linux-{aarch64,ppc64le}, or in the worst case, emulate them on azure (which is quite a bit slower, but since the build times here are not that big, that would also be an option).

@SwayamInSync
Copy link
Contributor Author

SwayamInSync commented Aug 21, 2024

Pinging the great @h-vetinari to see if they can assist as I my conda-forge-fu is not that strong.

Thanks for the flattery, but "stubborn" might be more accurate than "great". 😅

In any case, PPC is going to run into conda-forge/status#185. Since you're already cross-compiling osx-arm64, the hope would be that you could switch to cross-compilation also for linux-{aarch64,ppc64le}, or in the worst case, emulate them on azure (which is quite a bit slower, but since the build times here are not that big, that would also be an option).

Thanks @h-vetinari , switched to azure provider

provider: {linux_aarch64: azure, linux_ppc64le: azure}

Travis CI is still failing for ppc64le, but is it now to a point where we can merge it?
cc: @bluescarni

@bluescarni
Copy link
Contributor

Travis CI is still failing for ppc64le, but is it now to a point where we can merge it? cc: @bluescarni

I think you need to rerender the recipe.

@SwayamInSync
Copy link
Contributor Author

Travis CI is still failing for ppc64le, but is it now to a point where we can merge it? cc: @bluescarni

I think you need to rerender the recipe.

Thanks @bluescarni
Pushed the re-rendered one, seems good now

@bluescarni
Copy link
Contributor

@SwayamInSync cheers, LGTM, merging.

@bluescarni bluescarni merged commit 4394a86 into conda-forge:main Aug 22, 2024
8 checks passed
@SwayamInSync
Copy link
Contributor Author

Ahh I think by mistake I left this for windows 🥲

opening a new PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants