-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding quad-precision build support #9
Adding quad-precision build support #9
Conversation
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe/meta.yaml:
|
PR regarding issue #8 |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe/meta.yaml:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@bluescarni any thoughts on why the windows and Travis CI are failing? |
@SwayamInSync for the PPC64 build failure, I recall reading on the conda-forge gitter channel that there were issues with travis and that the solution was to switch to cross compilation from x86. Pinging the great @h-vetinari to see if they can assist as I my conda-forge-fu is not that strong. For the Windows build I don't really know... |
recipe/meta.yaml
Outdated
- {{ stdlib("c") }} | ||
- cmake | ||
- ninja # [unix] | ||
- make # [unix] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SwayamInSync I was wondering why is make
needed here, as the recipe on Unix uses ninja
as generator?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching that, make sense, I would've just put that there for my local use, will push a refactor commit for this
Thanks for the flattery, but "stubborn" might be more accurate than "great". 😅 In any case, PPC is going to run into conda-forge/status#185. Since you're already cross-compiling osx-arm64, the hope would be that you could switch to cross-compilation also for linux-{aarch64,ppc64le}, or in the worst case, emulate them on azure (which is quite a bit slower, but since the build times here are not that big, that would also be an option). |
Thanks @h-vetinari , switched to azure provider provider: {linux_aarch64: azure, linux_ppc64le: azure} Travis CI is still failing for |
I think you need to rerender the recipe. |
…nda-forge-pinning 2024.08.22.08.44.44
Thanks @bluescarni |
@SwayamInSync cheers, LGTM, merging. |
Ahh I think by mistake I left this for windows 🥲 opening a new PR |
This PR adds quad-precision support to the SLEEF conda-forge package. The changes enable the building and packaging of the quad-precision library (
libsleefquad
) alongside the existing SLEEF libraries.