Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: builds fail with ModuleNotFoundError for hatchling #37

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

iisakkirotko
Copy link
Contributor

@iisakkirotko iisakkirotko commented Aug 5, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Builds for new versions fail with

ModuleNotFoundError: No module named 'hatchling'

Even though hatchling is listed in all dependencies. Trying some stuff here.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@iisakkirotko iisakkirotko force-pushed the fix-build-no-hatchling branch 3 times, most recently from c8905bf to 2c9bde8 Compare August 5, 2024 09:38
@iisakkirotko
Copy link
Contributor Author

@conda-forge-admin, please rerender

@iisakkirotko iisakkirotko force-pushed the fix-build-no-hatchling branch 8 times, most recently from a59e3e0 to 41286c0 Compare August 5, 2024 13:46
@dhirschfeld
Copy link
Member

Try hatchling=1.22.2

@dhirschfeld
Copy link
Member

@iisakkirotko iisakkirotko force-pushed the fix-build-no-hatchling branch 2 times, most recently from 2ab9335 to 5842a9f Compare August 6, 2024 07:55
@iisakkirotko
Copy link
Contributor Author

Try hatchling=1.22.2

Doesn't seem to work either... It seems to me that something has changed about the build step - it seems to skip the installation of dependencies completely for the solara package.

They shouldn't be using exact pins upstream: https://github.com/widgetti/solara/blame/04cbe23a5cbd1124df0afa541c6d61939bc5a3cf/pyproject.toml#L2

What's even weirder is that apparently for the different subpackages of solara we use different versions, pinning ==1.22.2 for some, but only >=0.25 for others.

@iisakkirotko iisakkirotko force-pushed the fix-build-no-hatchling branch 4 times, most recently from c0d0166 to 339740b Compare August 6, 2024 10:03
@dhirschfeld
Copy link
Member

conda-build bug? I'd definitely report that to @conda-forge/core as, IIUC we shouldn't be touching those scripts since they will get overwritten with every rerender.

@hmaarrfk
Copy link

hmaarrfk commented Aug 6, 2024

But if you can reference or open an issue in conda-build it may be appropriate to break the rules!

@dhirschfeld
Copy link
Member

xref: conda/conda-build#5444

Because `PIP_` environmental variables are set in `conda-build` environments since version 7.24.0, and because our feedstock shared its name with one of the outputs, the `build` process of that output was effectively ignored.

See conda/conda-build#5444 for details.
@iisakkirotko iisakkirotko merged commit 3232b09 into conda-forge:main Aug 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants