Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DNM] Debug conda-libmamba-solver + conda-build #158

Closed
wants to merge 18 commits into from

Conversation

jaimergp
Copy link
Member

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@jaimergp
Copy link
Member Author

@conda-forge-admin, please rerender

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

conda-forge-webservices[bot] and others added 2 commits November 16, 2023 18:29
@jaimergp
Copy link
Member Author

@conda-forge-admin, please rerender

@jaimergp
Copy link
Member Author

This is very interesting 🤔 If I disable the build by adding some mockup build.sh, it does pass? Why would the build process affect the installability of the artifact if the metadata is identical? Trying again with the actual build.

@jaimergp
Copy link
Member Author

Indeed, very interesting 😱

Is conda-build modifying the Solver._index object at some point in certain stages of the post-build analysis? That's the only thing I can think of to explain why it fails with a full build but not with a mocked build.

@@ -79,7 +85,8 @@ if [[ "${BUILD_WITH_CONDA_DEBUG:-0}" == 1 ]]; then
# Drop into an interactive shell
/bin/bash
else
conda mambabuild "${RECIPE_ROOT}" -m "${CI_SUPPORT}/${CONFIG}.yaml" \
# export CONDA_VERBOSITY=3
conda build --debug "${RECIPE_ROOT}" -m "${CI_SUPPORT}/${CONFIG}.yaml" \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that's big boy log file we get XD

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like it only fails with

2023-11-22T20:46:38.5859860Z + python -c 'import lsst'
2023-11-22T20:46:38.5860312Z Traceback (most recent call last):
2023-11-22T20:46:38.5868623Z   File "<string>", line 1, in <module>
2023-11-22T20:46:38.5869792Z ModuleNotFoundError: No module named 'lsst'

which is expected due to the exit 0 in build_stackvana.sh.

# TEMPORARY:
pip install -U https://github.com/jaimergp/conda-build/archive/debug-cls-keyerror.tar.gz --no-deps
pip install -U git+https://github.com/conda/conda-libmamba-solver.git@conda-build-offline --no-deps
pip install -U https://github.com/jaimergp/conda/archive/investigate-cb-key-error.tar.gz --no-deps
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this gives any trouble, you could also do the

python -c "import pathlib, conda.plan; src = pathlib.Path(conda.plan.__file__); text = src.read_text().replace('stack_context_default', 'stack_context'); src.unlink(); src.write_text(text)"

spiel.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

investigate-cb-key-error also has some extra logging in case we hit a KeyError, and does not raise so the build can proceed without the report. I think the patch does work (you can see the repodata not being re-downloaded). The error is now about import lsst in the tests 🤷

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I saw conda/conda-libmamba-solver#393 (comment). Ok, reverting and rerunning.

@jaimergp
Copy link
Member Author

Look, it's passing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants