-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add libcufft recipe #21902
Add libcufft recipe #21902
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here are some missing changes from the 12.0.0 branch
Aha, just noticed the windows part of it, but not the rest, thanks! That also answers my question about the whitelist :) |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/cuda-libcufft:
|
Thanks to adibbley Co-authored-by: adibbley <103537006+adibbley@users.noreply.github.com>
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Also generally align all skips within a block to maximum indent
Please don't rename this to |
Ah, sorry! Do you have a quick idea why the builds are failing with:
I am experimenting with it, but don't really have a clear idea. Hmmm, I have been trying and chasing things but found nothing besides the use of |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding cuda-version
pinnings.
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@seberg I pushed commit f8e8938 with some minor fixes/changes to align with the libcublas recipe. Thank you so much for your help! @jakirkham @adibbley @leofang I think this is ready to go, so I'll approve it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's resolve open comment threads that are outdated.
I reviewed the recipe contents and upstream package contents carefully to ensure nothing is being missed. I have not yet validated the output package contents are complete but the tests should be covering us well. (However, I ran into an unexpected situation where tests were passing on libcublas despite having a test that I expected to fail. See conda-forge/libcublas-feedstock#10.) I can verify the package contents on Monday. This looks close enough that I feel comfortable approving it.
Thanks all! 🙏 Let's follow up on anything else in the feedstock 🙂 |
Attempt at cufft, lets see how far this gets, its my first attempt and I am still a bit confused about the whole setup.
Questions:
What about the static version for windows? Did I just miss it, or do I need to split it into its own yaml to not create it on windows? (or can a skip be added just for one of theNvm, adding the skip seems pretty straight forward.outputs
?)Was it correct to keep/use themissing_dso_whitelist
?cc @jakirkham, @adibbley
xref gh-21382
EDIT: Arrg, was meant as a draft of course, this probably needs a bit of work still.