Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AequilibraE #22437

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add AequilibraE #22437

wants to merge 3 commits into from

Conversation

Jake-Moss
Copy link

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/aequilibrae) and found it was in an excellent condition.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/aequilibrae) and found some lint.

Here's what I've got...

For recipes/aequilibrae:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [15]

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/aequilibrae) and found it was in an excellent condition.

@Jake-Moss
Copy link
Author

@conda-forge/help-python, ready for review

@Jake-Moss
Copy link
Author

Hi @conda-forge/staged-recipes @conda-forge/help-python this is ready for review

@pedrocamargo
Copy link

@conda-forge-manager , this is ready for review

@Jake-Moss
Copy link
Author

@conda-forge/help-python

recipes/aequilibrae/meta.yaml Outdated Show resolved Hide resolved
@Jake-Moss
Copy link
Author

@conda-forge/help-python, ready for review

Copy link
Member

@carterbox carterbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't install tests to site-packages.

This recipe is installing tests to site-packages/tests. If you really want your users to have tests, they should be installed to site-packages/aquilibrae/tests or $PREFIX/opt/acquilibrae/tests or $PREFIX/doc/acquilibrae/tests

Don't install requirements.txt to site-packages.

Don't install version.py to site-packages.

Probably, this package needs to update its MANIFEST.in or setup.py to not install these extra files.

@pedrocamargo
Copy link

Any possibility of following up on this?

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Nov 6, 2024

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/aequilibrae/meta.yaml) and found some lint.

Here's what I've got...

For recipes/aequilibrae/meta.yaml:

  • In your conda_build_config.yaml, please change the name of MACOSX_DEPLOYMENT_TARGET, to c_stdlib_version!

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict. Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

Bump aequilibrae version to fix build issues

Depend on openmp

Disable availability checks for osx

Bump verions to 0.8.3

Bump AequilibraE, address comments

Bump hash

Add pip to host

Bump AequilibraE or 1.0.1

Add openmartix as dep

Add geopandas

Bump AequilibraE to 1.1.2

pypi.io -> pypi.org, add stdlib build dependency

Change MACOSX_DEPLOYMENT_TARGET -> c_stdlib_version
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/aequilibrae/meta.yaml) and found it was in an excellent condition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants