-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AequilibraE #22437
base: main
Are you sure you want to change the base?
Add AequilibraE #22437
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/aequilibrae:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge/help-python, ready for review |
Hi @conda-forge/staged-recipes @conda-forge/help-python this is ready for review |
@conda-forge-manager , this is ready for review |
@conda-forge/help-python |
@conda-forge/help-python, ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't install tests to site-packages.
This recipe is installing tests to site-packages/tests. If you really want your users to have tests, they should be installed to site-packages/aquilibrae/tests or $PREFIX/opt/acquilibrae/tests or $PREFIX/doc/acquilibrae/tests
Don't install requirements.txt to site-packages.
Don't install version.py to site-packages.
Probably, this package needs to update its MANIFEST.in or setup.py to not install these extra files.
Any possibility of following up on this? |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/aequilibrae/meta.yaml:
|
Hi! This is the friendly automated conda-forge-linting service. I was trying to look for recipes to lint for you, but it appears we have a merge conflict. Please try to merge or rebase with the base branch to resolve this conflict. Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug. |
Bump aequilibrae version to fix build issues Depend on openmp Disable availability checks for osx Bump verions to 0.8.3 Bump AequilibraE, address comments Bump hash Add pip to host Bump AequilibraE or 1.0.1 Add openmartix as dep Add geopandas Bump AequilibraE to 1.1.2 pypi.io -> pypi.org, add stdlib build dependency Change MACOSX_DEPLOYMENT_TARGET -> c_stdlib_version
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).