-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add greedy #28069
base: main
Are you sure you want to change the base?
Add greedy #28069
Conversation
Hi! This is the staged-recipes linter and I found some lint. File-specific lints and/or hints:
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/greedy/meta.yaml:
|
…sort to a single recipe maintainer
Hi! This is the staged-recipes linter and your PR looks excellent! 🚀 |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/greedy/meta.yaml:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge/help-c-cpp ready for review please! |
# A dummy greedy repo is cloned because CMakeLists.txt requires | ||
# .git dir | ||
|
||
# Clone the repository into a temporary directory | ||
git clone https://github.com/pyushkevich/greedy /tmp/greedy | ||
|
||
# Change to the directory where the source is located | ||
cd /tmp/greedy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should patch the sources rather than doing this.
Also the current implementation of this completely ignores the version number and just takes the latest version of the sources.
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).