Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear libmamba .solv cache #5428

Merged

Conversation

kenodegard
Copy link
Contributor

@kenodegard kenodegard commented Jul 26, 2024

Description

conda-libmamba-solver 24.7.0 reuses the .solv cache by default. This means toggling the add_pip_as_python_dependency value doesn't have an impact until the cache is cleared.

Here we use a temporary directory for the cache to avoid the issue.

Xref #5426
Resolves conda/conda-libmamba-solver#506
Xref conda/conda-libmamba-solver#393
Xref conda/conda-libmamba-solver#481
Xref conda/conda-libmamba-solver#482

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Jul 26, 2024
Copy link

codspeed-hq bot commented Jul 26, 2024

CodSpeed Performance Report

Merging #5428 will not alter performance

Comparing kenodegard:clear-cache-add_pip_as_python_dependency (9a5fd86) with main (6b222c7)

Summary

✅ 3 untouched benchmarks

@kenodegard kenodegard requested a review from jaimergp July 29, 2024 14:48
@kenodegard kenodegard marked this pull request as ready for review July 29, 2024 14:48
@kenodegard kenodegard requested a review from a team as a code owner July 29, 2024 14:48
@kenodegard kenodegard merged commit 6dbdec8 into conda:main Jul 29, 2024
30 checks passed
@kenodegard kenodegard deleted the clear-cache-add_pip_as_python_dependency branch July 29, 2024 16:43
kenodegard added a commit to kenodegard/conda-build that referenced this pull request Jul 29, 2024
@kenodegard kenodegard mentioned this pull request Jul 29, 2024
3 tasks
jezdez pushed a commit that referenced this pull request Jul 30, 2024
* Clear libmamba `.solv` cache (#5428)

* Check WSL exists first
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

24.7.0 regression: add_pip_as_python_dependency
3 participants