Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infer missing noarch type from subdir and dependencies #257

Merged
merged 2 commits into from
Aug 11, 2023
Merged

Conversation

jaimergp
Copy link
Contributor

@jaimergp jaimergp commented Aug 10, 2023

Description

Needed bit to fix test_windows_sort_orders_1 upstream. libmamba doesn't return the noarch field in their JSON payloads carrying the PackageRecord kwargs. We will report upstream but for now we can infer the type (more or less) from the subdir and the dependency list.

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Aug 10, 2023
@jaimergp jaimergp marked this pull request as ready for review August 11, 2023 06:20
@jaimergp jaimergp merged commit 0d61184 into main Aug 11, 2023
61 of 71 checks passed
@jaimergp
Copy link
Contributor Author

Opened mamba-org/mamba#2746

@jaimergp jaimergp added this to the September 2023 release milestone Sep 25, 2023
@jaimergp jaimergp deleted the infer-noarch branch November 7, 2023 10:24
@github-actions github-actions bot added the locked [bot] locked due to inactivity label Nov 7, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants