Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ctrl+c signals to be caught #338

Closed
wants to merge 2 commits into from
Closed

Allow ctrl+c signals to be caught #338

wants to merge 2 commits into from

Conversation

jaimergp
Copy link
Contributor

Description

See mamba-org/mamba#1594 for a more detailed discussion.

Closes #337 in a hacky way 🥷

cc @dholth

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Oct 27, 2023
@dholth
Copy link
Contributor

dholth commented Oct 27, 2023

I would be interested in comparing this method with a call to https://docs.python.org/3/library/signal.html#signal.pthread_sigmask or patching upstream.

Also, is libmamba-solver starting a special thread that's there just to catch signals using sigwait?

@jaimergp
Copy link
Contributor Author

Superseded by #340

@jaimergp jaimergp closed this Oct 30, 2023
@jezdez jezdez deleted the ctrl-c-workaround branch November 2, 2023 17:31
@github-actions github-actions bot added the locked [bot] locked due to inactivity label Nov 2, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Handle CTRL-C gracefully when using conda-libmamba-solver
3 participants