Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update recipe to attempt to fix local build failure #339

Closed
wants to merge 1 commit into from

Conversation

dholth
Copy link
Contributor

@dholth dholth commented Oct 27, 2023

Description

I wasn't able to conda-build the embedded recipe, not because of noarch. This works better. Still having trouble with hatch, hatch-vcs, and pip's idea of what a valid version number is however.

Also, call pthread_sigmask . I tested this on OSX and you can't press CTRL-C at all without it. It's still unreliable to interrupt download threads but that is being worked on in conda/conda#13246

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Oct 27, 2023
@jaimergp
Copy link
Contributor

Hi Daniel! Why is this needed? We are mimicking conda-forge noarch recipe on purpose.

If this is for development, I think we have some instructions in the docs.

@dholth dholth changed the title Update recipe based on anacondarecipes feedstock Call pthread_sigmask to disable libmamba signal handler and hopefully re-enable Python's Oct 27, 2023
@dholth
Copy link
Contributor Author

dholth commented Oct 27, 2023

@jaimergp this is needed because "conda-build ." fails on a checkout of the main branch.

@dholth dholth changed the title Call pthread_sigmask to disable libmamba signal handler and hopefully re-enable Python's Call pthread_sigmask to disable libmamba signal handler and re-enable Python's Oct 27, 2023
@beeankha
Copy link
Member

pre-commit.ci autofix

@jezdez
Copy link
Member

jezdez commented Oct 28, 2023

It's worth separating the packaging related proposal here into another PR.

@dholth dholth changed the title Call pthread_sigmask to disable libmamba signal handler and re-enable Python's Update recipe to attempt to fix local build failure Oct 28, 2023
@jaimergp
Copy link
Contributor

I don't think there's anything wrong with the recipe. conda build recipe/ should work correctly in a clean workspace (e.g. CONDA_BLD_PATH=~/tmp/new-build-workspace conda build recipe/).

However, I've noticed that we will error with traceback due to a bad argument in the exception chain. This can be reproduced if the conda-build local channel contains packages in the dependency tree that would shadow the remote channels (e.g. if you have built a conda package recently, that's in your CONDA_BLD_PATH channel, so it will shadow your remote defaults or conda-forge conda package due to strict priority). When that happens, we error out with a solver conflict, but the exception is built with a missing argument, and it fails badly. I'll open a separate PR to address that, but I'm closing this one.

@jaimergp jaimergp closed this Oct 30, 2023
@github-actions github-actions bot added the locked [bot] locked due to inactivity label Oct 31, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed [bot] added once the contributor has signed the CLA locked [bot] locked due to inactivity
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants