Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable --offline installs from pkgs_dirs #423

Merged
merged 12 commits into from
Jan 25, 2024
Merged

Enable --offline installs from pkgs_dirs #423

merged 12 commits into from
Jan 25, 2024

Conversation

jaimergp
Copy link
Contributor

@jaimergp jaimergp commented Jan 16, 2024

Description

Closes #396

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Jan 16, 2024
@jaimergp
Copy link
Contributor Author

Needs conda/conda#13507

@jaimergp jaimergp changed the title Use SubdirData.cache_path_json directly if --offline or --use-index-cache are in use Enable --offline installs from pkgs_dirs Jan 17, 2024
@jaimergp jaimergp closed this Jan 17, 2024
@jaimergp jaimergp reopened this Jan 17, 2024
@jaimergp
Copy link
Contributor Author

I can't reproduce locally:

FAILED tests/cli/test_main_clean.py::test_clean_tarballs - AssertionError: assert False
 +  where False = has_pkg('zlib', [])
 +    where [] = _get_tars('/var/folders/mm/pltwc2yj1jx192t6dzy9zsrr0000gn/T/1dd3 dcafbe/pkgs')
FAILED tests/cli/test_main_clean.py::test_clean_all[True] - AssertionError: assert False
 +  where False = has_pkg('zlib', [PosixPath('/var/folders/mm/pltwc2yj1jx192t6dzy9zsrr0000gn/T/9650 cbfdae/pkgs/cache')])
FAILED tests/cli/test_main_clean.py::test_clean_all_mock_lstat[True] - AssertionError: assert False
 +  where False = has_pkg('zlib', [PosixPath('/var/folders/mm/pltwc2yj1jx192t6dzy9zsrr0000gn/T/beba ecfdab/pkgs/cache')])

It's like that pkgs cache is not functional for those tests. This only happens on macOS, so I wonder if there's a side effect introduced by other tests.

@jaimergp
Copy link
Contributor Author

Actually these are also failing on main, so I'd say it's not related to this PR at all.

conda_libmamba_solver/solver.py Outdated Show resolved Hide resolved
tests/test_channels.py Outdated Show resolved Hide resolved
@jezdez jezdez merged commit d16e1b3 into main Jan 25, 2024
71 checks passed
@jezdez jezdez deleted the offline-use-cache branch January 25, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Network options --offline and -C fails after new Miniconda installation with libmamba solver as default.
3 participants