Update menuinst/platforms/win.py

Co-authored-by: jaimergp <jaimergp@users.noreply.github.com>
conda · Jun 5, 2024 · 707e3df · 707e3df
1 parent bf42914
commit 707e3df
Showing 1 changed file with 8 additions and 6 deletions.
diff --git a/menuinst/platforms/win.py b/menuinst/platforms/win.py
@@ -37,13 +37,15 @@ def create(self) -> Tuple[os.PathLike]:
 
     def remove(self) -> Tuple[os.PathLike]:
         # Only remove if the Start Menu directory is empty in case applications share a folder.
-        try:
-            menu_location = Path(self.start_menu_location)
-            if menu_location.exists():
+        menu_location = Path(self.start_menu_location)
+        if menu_location.exists():
+            try:
+                # Check directory contents. If empty, it will raise StopIteration
+                # and only in that case we delete the directory.
                 next(menu_location.iterdir())
-        except StopIteration:
-            log.debug("Removing %s", self.start_menu_location)
-            shutil.rmtree(self.start_menu_location, ignore_errors=True)
+            except StopIteration:
+                log.debug("Removing %s", self.start_menu_location)
+                shutil.rmtree(self.start_menu_location, ignore_errors=True)
         return (self.start_menu_location,)
 
     @property