Backport v2 privilege elevation logic to v1 #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conda-bot
added
the
cla-signed
jaimergp
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current menuinst legacy implementation does not work with
conda-standalone. Trying to runconda.exe remove -p <prefix> --allwill cause an error where menuinst cannot find the python binary. This happens when menuinst is trying to elevate privileges because it only looks for.nonadminfiles in theroot_prefix.This PR backports some of the menuinst v2 logic to be more robust for conda-standalone. Note that I decided to not use the
needs_adminfunction because it makes additional assumptions. Specifically, it returnsFalseif the user is already admin, which is not consistent with menuinst v1 behavior.Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?