docs(examples): migrate agentspan CLI references to the conductor CLI - #171
Merged
Merged
Conversation
ling-senpeng13
force-pushed
the
chore/migrate-examples-to-conductor-cli
branch
from
August 20, 2026 00:53
6669685 to
796a2d9
Compare
ling-senpeng13
marked this pull request as ready for review
August 20, 2026 01:17
ambiorix2099
left a comment
ambiorix2099
left a comment
There was a problem hiding this comment.
CI is red, but it's pre-existing, and this branch only touches comments under examples/.
Since we don't merge on red, would it make sense to land a CI fix separately and rebase this on top?
ling-senpeng13
force-pushed
the
chore/migrate-examples-to-conductor-cli
branch
from
August 20, 2026 22:25
796a2d9 to
87353bf
Compare
kowser-orkes
approved these changes
Aug 20, 2026
The agentspan CLI was folded into the conductor CLI (conductor-oss/conductor-cli
"Combine agentspan cli to conductor", 2026-06-30). The examples still documented
the retired binary, and their --package paths pointed at the pre-port monorepo
layout (sdk/typescript/examples), so none of the commented deploy commands would
have worked as written.
Command mapping, verified against conductor-cli origin/main:
agentspan deploy --package sdk/typescript/examples[/<fw>]
-> conductor deploy --package examples/agents[/<fw>] (196)
agentspan credentials set <k> <v> -> conductor secret put <k> <v> (31)
agentspan login -> conductor config save (3)
agentspan run <name> "prompt" -> conductor agent run --name <name> (1)
deploy keeps its -p/-a/-l/--json flags; credentials became secret and uses put,
not set; login has no direct successor, so config save (interactive server+auth
setup) replaces it.
Also drops two stale monorepo paths and two naming leftovers:
- kitchen-sink.ts called discoverAgents('sdk/typescript/examples'), a live path
to a directory that does not exist; its try/catch swallowed the failure.
- dump-agent-configs.ts documented "cd sdk/typescript && npx tsx examples/...".
- "Run on agentspan" section headers -> "Run on Conductor" (96). Conductor is
also 9 characters, so the box-drawing padding is unchanged.
- "CONDUCTOR_SERVER_URL for [the] agentspan path" (45) -> the house-style line.
That qualifier implied an alternative non-Conductor path, but all 36 ADK and
all 10 OpenAI examples carrying it construct AgentRuntime, so the variable is
required unconditionally.
Left as-is: agentspan.default-context-window (a real server property), the
'agentspan' GitHub-org search literals, and prose describing the agentspan
module itself. Wire-protocol identifiers (__agentspan_ctx__, _agentspan,
AgentspanMetadata) are untouched.
One behavioral line: 16b-credentials-non-isolated.ts emits the new
"conductor secret put" hint in a runtime error string, not a comment.
Prerequisite comment lines also drop the redundant " as environment variable"
suffix (203 lines, 125 files) -- the "NAME=value" form already reads as an env
var, and the shorter line matches the rest of the block.
tsc --noEmit reports 285 errors, unchanged from the pre-change baseline.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
ling-senpeng13
force-pushed
the
chore/migrate-examples-to-conductor-cli
branch
from
August 20, 2026 23:05
87353bf to
5a4436a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The agentspan CLI was folded into the conductor CLI in conductor-oss/conductor-cli#89. The examples still documented the retired binary, and their
--packagepaths pointed at the pre-port monorepo layout (sdk/typescript/examples) — so none of the commented deploy commands worked as written.Mapping, verified against
conductor-cliorigin/main:deploy --package sdk/typescript/examples[/<fw>]deploy --package examples/agents[/<fw>]credentials set <k> <v>secret put <k> <v>loginconfig saverun <name> "prompt"agent run --name <name> "prompt"Also:
Run on agentspan→Run on Conductor(96, padding unchanged — both 9 chars);CONDUCTOR_SERVER_URL for [the] agentspan path→ the house-style line (45, the qualifier implied a non-Conductor path that no example offers); and two stalesdk/typescriptpaths.tsc --noEmit: 285 errors, unchanged from baseline.