Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: updated v8 client to support multiple index and added test cases #92

Merged
merged 7 commits into from
Oct 22, 2024
Merged

feat: updated v8 client to support multiple index and added test cases #92

merged 7 commits into from
Oct 22, 2024

Conversation

grvsahil
Copy link
Contributor

@grvsahil grvsahil commented Sep 18, 2024 •
edited
Loading

Description

This PR includes:

  • Updated v5, v6, v7, v8 clients to support multiple collections
  • Added more test cases to improve the coverage
  • Handled the response status 404 in case of inexistent records
  • Attached the status to the error message in case of an unknown error
  • Updated README to include changes for index

Quick checks:

  • I have followed the Code Guidelines.
  • There is no other pull request for the same update/change.
  • I have written unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

@grvsahil grvsahil added the wip Work in progress label Sep 18, 2024
lovromazgon
lovromazgon reviewed Sep 18, 2024
View reviewed changes
Copy link
Contributor

@lovromazgon lovromazgon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally the approach makes sense, keep going 👍

destination/config.go Outdated Show resolved Hide resolved
internal/elasticsearch/v8/client.go Outdated Show resolved Hide resolved
@grvsahil grvsahil marked this pull request as ready for review September 20, 2024 06:59
@grvsahil grvsahil requested a review from a team as a code owner September 20, 2024 06:59
@grvsahil grvsahil removed the wip Work in progress label Sep 24, 2024
lovromazgon
lovromazgon reviewed Oct 15, 2024
View reviewed changes
destination/config.go Outdated Show resolved Hide resolved
lovromazgon
lovromazgon approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@lovromazgon lovromazgon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@grvsahil grvsahil merged commit 06f6918 into main Oct 22, 2024
3 checks passed
@grvsahil grvsahil deleted the feature/multiple-collection-support branch October 22, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lovromazgon lovromazgon lovromazgon approved these changes

Assignees

@grvsahil grvsahil

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grvsahil @lovromazgon